From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <matt@ranostay.consulting>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: health: max30100: fixed parenthesis around FIFO count check
Date: Sat, 21 Jan 2017 14:18:04 +0000 [thread overview]
Message-ID: <16c409d4-7d51-355f-a397-375aae301305@kernel.org> (raw)
In-Reply-To: <20170117020418.23359-1-matt@ranostay.consulting>
On 17/01/17 02:04, Matt Ranostay wrote:
> FIFO was being read every sample after the "almost full" state was
> reached. This was due to an incorrect placement of the parenthesis
> in the while condition check.
>
> Signed-off-by: Matt Ranostay <matt@ranostay.consulting>
Fixes tags please in future. I've applied this to the fixes-togreg
branch and marked for stable with a fixes tag of the last patch to
touch that line (which isn't really correct, but a backport would require
that patch anyway in addition to this one).
Jonathan
> ---
> drivers/iio/health/max30100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/health/max30100.c b/drivers/iio/health/max30100.c
> index 90ab8a2d2846..183c14329d6e 100644
> --- a/drivers/iio/health/max30100.c
> +++ b/drivers/iio/health/max30100.c
> @@ -238,7 +238,7 @@ static irqreturn_t max30100_interrupt_handler(int irq, void *private)
>
> mutex_lock(&data->lock);
>
> - while (cnt || (cnt = max30100_fifo_count(data) > 0)) {
> + while (cnt || (cnt = max30100_fifo_count(data)) > 0) {
> ret = max30100_read_measurement(data);
> if (ret)
> break;
>
next prev parent reply other threads:[~2017-01-21 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 2:04 [PATCH] iio: health: max30100: fixed parenthesis around FIFO count check Matt Ranostay
2017-01-21 14:18 ` Jonathan Cameron [this message]
2017-01-22 4:55 ` Matt Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16c409d4-7d51-355f-a397-375aae301305@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=matt@ranostay.consulting \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).