From: Rob Herring <robh@kernel.org>
To: Nuno Sa <nuno.sa@analog.com>
Cc: devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Conor Dooley <conor+dt@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-iio@vger.kernel.org,
Olivier Moysan <olivier.moysan@foss.st.com>,
Frank Rowand <frowand.list@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Michael Hennerich <Michael.Hennerich@analog.com>
Subject: Re: [PATCH v7 3/9] dt-bindings: adc: axi-adc: update bindings for backend framework
Date: Tue, 23 Jan 2024 10:36:46 -0600 [thread overview]
Message-ID: <170602780540.972855.11472809528019876011.robh@kernel.org> (raw)
In-Reply-To: <20240123-iio-backend-v7-3-1bff236b8693@analog.com>
On Tue, 23 Jan 2024 16:14:24 +0100, Nuno Sa wrote:
> 'adi,adc-dev' is now deprecated and must not be used anymore. Hence,
> also remove it from being required.
>
> The reason why it's being deprecated is because the axi-adc CORE is now
> an IIO service provider hardware (IIO backends) for consumers to make use
> of. Before, the logic with 'adi,adc-dev' was the opposite (it was kind
> of consumer referencing other nodes/devices) and that proved to be wrong
> and to not scale.
>
> Now, IIO consumers of this hardware are expected to reference it using the
> io-backends property. Hence, the new '#io-backend-cells' is being added
> so the device is easily identified as a provider.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Nuno Sa <nuno.sa@analog.com>
> ---
> Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml:45:5: [error] syntax error: could not find expected ':' (syntax)
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml:45:5: could not find expected ':'
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml: ignoring, error parsing file
make[2]: *** Deleting file 'Documentation/devicetree/bindings/iio/adc/adi,axi-adc.example.dts'
Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml:45:5: could not find expected ':'
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/iio/adc/adi,axi-adc.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1428: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240123-iio-backend-v7-3-1bff236b8693@analog.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-01-23 16:36 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 15:14 [PATCH v7 0/9] iio: add new backend framework Nuno Sa via B4 Relay
2024-01-23 15:14 ` [PATCH v7 1/9] of: property: fix typo in io-channels Nuno Sa via B4 Relay
2024-01-25 3:14 ` Saravana Kannan
2024-01-27 15:07 ` Jonathan Cameron
2024-01-27 15:16 ` Jonathan Cameron
2024-01-29 8:18 ` Nuno Sá
2024-01-29 22:33 ` Saravana Kannan
2024-01-30 10:32 ` Nuno Sá
2024-01-30 20:54 ` Rob Herring
2024-01-30 20:54 ` Rob Herring
2024-01-31 8:55 ` Nuno Sá
2024-01-23 15:14 ` [PATCH v7 2/9] dt-bindings: adc: ad9467: add new io-backend property Nuno Sa via B4 Relay
2024-01-23 15:14 ` [PATCH v7 3/9] dt-bindings: adc: axi-adc: update bindings for backend framework Nuno Sa via B4 Relay
2024-01-23 16:36 ` Rob Herring [this message]
2024-01-23 15:14 ` [PATCH v7 4/9] driver: core: allow modifying device_links flags Nuno Sa via B4 Relay
2024-01-25 3:21 ` Saravana Kannan
2024-01-25 8:14 ` Nuno Sá
2024-01-25 15:34 ` Nuno Sá
2024-01-25 16:57 ` Rafael J. Wysocki
2024-01-26 8:04 ` Nuno Sá
2024-01-26 14:26 ` Nuno Sá
2024-01-27 15:15 ` Jonathan Cameron
2024-01-29 8:29 ` Nuno Sá
2024-01-29 22:31 ` Saravana Kannan
2024-01-30 10:54 ` Nuno Sá
2024-01-26 0:57 ` Saravana Kannan
2024-01-26 8:05 ` Nuno Sá
2024-01-26 0:50 ` Saravana Kannan
2024-01-26 8:13 ` Nuno Sá
2024-01-26 14:27 ` Nuno Sá
2024-01-26 18:09 ` Saravana Kannan
2024-01-27 8:43 ` Nuno Sá
2024-01-23 15:14 ` [PATCH v7 5/9] of: property: add device link support for io-backends Nuno Sa via B4 Relay
2024-01-23 15:14 ` [PATCH v7 6/9] iio: buffer-dmaengine: export buffer alloc and free functions Nuno Sa via B4 Relay
2024-01-23 15:14 ` [PATCH v7 7/9] iio: add the IIO backend framework Nuno Sa via B4 Relay
2024-01-23 15:14 ` [PATCH v7 8/9] iio: adc: ad9467: convert to " Nuno Sa via B4 Relay
2024-01-23 15:14 ` [PATCH v7 9/9] iio: adc: adi-axi-adc: move " Nuno Sa via B4 Relay
2024-01-27 15:20 ` Jonathan Cameron
2024-01-28 21:27 ` David Lechner
2024-01-29 8:15 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170602780540.972855.11472809528019876011.robh@kernel.org \
--to=robh@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox