From: Rob Herring <robh@kernel.org>
To: "Ondřej Jirman" <megi@xff.cz>
Cc: linux-iio@vger.kernel.org, Icenowy Zheng <icenowy@aosc.io>,
devicetree@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Andrey Skvortsov <andrej.skvortzov@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH 2/4] dt-bindings: iio: magnetometer: Add DT binding for Voltafield AF8133J
Date: Sun, 11 Feb 2024 16:32:39 -0600 [thread overview]
Message-ID: <170769075818.2433614.5244889858722764083.robh@kernel.org> (raw)
In-Reply-To: <20240211205211.2890931-3-megi@xff.cz>
On Sun, 11 Feb 2024 21:51:58 +0100, Ondřej Jirman wrote:
> From: Icenowy Zheng <icenowy@aosc.io>
>
> Voltafield AF8133J is a simple magnetometer sensor produced by Voltafield
> Technology Corp, with dual power supplies (one for core and one for I/O)
> and active-low reset pin.
>
> The sensor has configurable range 1.2 - 2.2 mT and a software controlled
> standby mode.
>
> Add a device tree binding for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> Signed-off-by: Ondřej Jirman <megi@xff.cz>
> ---
> .../iio/magnetometer/voltafield,af8133j.yaml | 58 +++++++++++++++++++
> 1 file changed, 58 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml: properties:compatible: ['voltafield,af8133j'] is not of type 'object', 'boolean'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml: properties:compatible: ['voltafield,af8133j'] is not of type 'object', 'boolean'
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml: ignoring, error in schema: properties: compatible
Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.example.dtb: /example-0/i2c/magnetometer@1c: failed to match any schema with compatible: ['voltafield,af8133j']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240211205211.2890931-3-megi@xff.cz
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-02-11 22:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 20:51 [PATCH 0/4] Add support for AF8133J magnetometer Ondřej Jirman
2024-02-11 20:51 ` [PATCH 1/4] dt-bindings: vendor-prefix: Add prefix for Voltafield Ondřej Jirman
2024-02-12 7:58 ` Krzysztof Kozlowski
2024-02-11 20:51 ` [PATCH 2/4] dt-bindings: iio: magnetometer: Add DT binding for Voltafield AF8133J Ondřej Jirman
2024-02-11 22:32 ` Rob Herring [this message]
2024-02-12 11:47 ` Jonathan Cameron
2024-02-12 13:38 ` Ondřej Jirman
2024-02-14 16:31 ` Jonathan Cameron
2024-02-14 17:29 ` Conor Dooley
2024-02-14 17:44 ` Ondřej Jirman
2024-02-12 12:05 ` kernel test robot
2024-02-11 20:51 ` [PATCH 3/4] MAINTAINERS: Add an entry for AF8133J driver Ondřej Jirman
2024-02-12 7:59 ` Krzysztof Kozlowski
2024-02-11 20:52 ` [PATCH 4/4] iio: magnetometer: add a driver for Voltafield AF8133J magnetometer Ondřej Jirman
2024-02-12 12:04 ` kernel test robot
2024-02-12 13:02 ` Jonathan Cameron
2024-02-12 15:04 ` Ondřej Jirman
2024-02-14 16:28 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170769075818.2433614.5244889858722764083.robh@kernel.org \
--to=robh@kernel.org \
--cc=andrej.skvortzov@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=megi@xff.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox