Linux IIO development
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: marius.cristea@microchip.com
Cc: linux-hwmon@vger.kernel.org, lars@metafoo.de, jic23@kernel.org,
	 krzysztof.kozlowski+dt@linaro.org, linux-iio@vger.kernel.org,
	 robh+dt@kernel.org, devicetree@vger.kernel.org,
	jdelvare@suse.com,  linux@roeck-us.net, conor+dt@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: iio: adc: adding support for PAC193X
Date: Thu, 22 Feb 2024 10:45:02 -0700	[thread overview]
Message-ID: <170862389650.3483951.10645767474712290486.robh@kernel.org> (raw)
In-Reply-To: <20240222164206.65700-2-marius.cristea@microchip.com>


On Thu, 22 Feb 2024 18:42:05 +0200, marius.cristea@microchip.com wrote:
> From: Marius Cristea <marius.cristea@microchip.com>
> 
> This is the device tree schema for iio driver for
> Microchip PAC193X series of Power Monitors with Accumulator.
> 
> Signed-off-by: Marius Cristea <marius.cristea@microchip.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  .../bindings/iio/adc/microchip,pac1934.yaml   | 120 ++++++++++++++++++
>  1 file changed, 120 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/microchip,pac1934.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/iio/adc/microchip,pac1934.yaml:51:9: [warning] wrong indentation: expected 6 but found 8 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240222164206.65700-2-marius.cristea@microchip.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-02-22 17:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 16:42 [PATCH v5 0/2] adding support for Microchip PAC193X Power Monitor marius.cristea
2024-02-22 16:42 ` [PATCH v5 1/2] dt-bindings: iio: adc: adding support for PAC193X marius.cristea
2024-02-22 17:45   ` Rob Herring [this message]
2024-02-24  7:34   ` kernel test robot
2024-02-24 19:14     ` Jonathan Cameron
2024-02-22 16:42 ` [PATCH v5 2/2] iio: adc: adding support for PAC193x marius.cristea
2024-02-24 19:15   ` Jonathan Cameron
2024-04-05 12:41     ` Conor Dooley
2024-04-05 12:53       ` Marius.Cristea
2024-04-05 16:14         ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170862389650.3483951.10645767474712290486.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marius.cristea@microchip.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox