From: "Rob Herring (Arm)" <robh@kernel.org>
To: marius.cristea@microchip.com
Cc: conor+dt@kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, jic23@kernel.org,
devicetree@vger.kernel.org, oskar.andero@gmail.com,
krzk+dt@kernel.org, lars@metafoo.de
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: adding support for PAC194X
Date: Mon, 17 Mar 2025 05:20:16 -0500 [thread overview]
Message-ID: <174220681643.3406351.8233477682051642594.robh@kernel.org> (raw)
In-Reply-To: <20250317090803.30003-2-marius.cristea@microchip.com>
On Mon, 17 Mar 2025 11:08:02 +0200, marius.cristea@microchip.com wrote:
> From: Marius Cristea <marius.cristea@microchip.com>
>
> This is the device tree schema for iio driver for Microchip PAC194X and
> PAC195X series of Power Monitors with Accumulator.
> The PAC194X family supports 9V Full-Scale Range and the PAC195X supports
> 32V Full-Scale Range.
> There are two versions of the PAC194X/5X: the PAC194X/5X-1 devices are
> for high-side current sensing and the PAC194X/5X-2 devices are for
> low-side current sensing or floating VBUS applications.
> The PAC194X/5X-1 is named shortly PAC194X/5X.
>
> Signed-off-by: Marius Cristea <marius.cristea@microchip.com>
> ---
> .../bindings/iio/adc/microchip,pac1944.yaml | 195 ++++++++++++++++++
> 1 file changed, 195 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/microchip,pac1944.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/microchip,pac1944.yaml: properties:interrupt-names:items: {'enum': ['alert1', 'alert2']} is not of type 'array'
from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250317090803.30003-2-marius.cristea@microchip.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-03-17 10:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 9:08 [PATCH v2 0/2] adding support for Microchip PAC194X Power Monitor marius.cristea
2025-03-17 9:08 ` [PATCH v2 1/2] dt-bindings: iio: adc: adding support for PAC194X marius.cristea
2025-03-17 10:20 ` Rob Herring (Arm) [this message]
2025-03-17 12:32 ` Jonathan Cameron
2025-03-17 9:08 ` [PATCH v2 2/2] " marius.cristea
2025-03-17 18:47 ` Jonathan Cameron
2025-03-18 7:05 ` kernel test robot
2025-03-18 7:53 ` kernel test robot
2025-03-19 7:30 ` kernel test robot
2025-03-24 5:57 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174220681643.3406351.8233477682051642594.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marius.cristea@microchip.com \
--cc=oskar.andero@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox