Linux IIO development
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Kim Seer Paller <kimseer.paller@analog.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Michael Hennerich <Michael.Hennerich@analog.com>,
	linux-iio@vger.kernel.org,  linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,  Jonathan Cameron <jic23@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH 3/4] dt-bindings: iio: dac: Add adi,ad3530r.yaml
Date: Wed, 19 Mar 2025 00:22:42 -0500	[thread overview]
Message-ID: <174236176222.620075.12480666866175403765.robh@kernel.org> (raw)
In-Reply-To: <20250319-togreg-v1-3-d8244a502f2c@analog.com>


On Wed, 19 Mar 2025 11:47:57 +0800, Kim Seer Paller wrote:
> The AD3530R/AD3530 is an 8-Channel, 16-Bit Voltage Output DAC, while the
> AD3531R/AD3531 is a 4-Channel, 16-Bit Voltage Output DAC. These devices
> include software-programmable gain controls that provide full-scale
> output spans of 2.5V or 5V for reference voltages of 2.5V. They operate
> from a single supply voltage range of 2.7V to 5.5V and are guaranteed to
> be monotonic by design. Additionally, these devices features a 2.5V,
> 5ppm/°C internal reference, which is disabled by default.
> 
> This adds the documentation for ad3530r.
> 
> Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
> ---
>  .../devicetree/bindings/iio/dac/adi,ad3530r.yaml   | 89 ++++++++++++++++++++++
>  MAINTAINERS                                        |  1 +
>  2 files changed, 90 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.example.dtb: adc@0: pwm-names: ['convst1'] is too short
	from schema $id: http://devicetree.org/schemas/iio/adc/adi,ad7606.yaml#

doc reference errors (make refcheckdocs):
Warning: Documentation/arch/powerpc/cxl.rst references a file that doesn't exist: Documentation/ABI/testing/sysfs-class-cxl
Warning: lib/Kconfig.debug references a file that doesn't exist: Documentation/dev-tools/fault-injection/fault-injection.rst
Documentation/arch/powerpc/cxl.rst: Documentation/ABI/testing/sysfs-class-cxl
lib/Kconfig.debug: Documentation/dev-tools/fault-injection/fault-injection.rst

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250319-togreg-v1-3-d8244a502f2c@analog.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-03-19  5:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-19  3:47 [PATCH 0/4] Add driver for AD3530R and AD3531R DACs Kim Seer Paller
2025-03-19  3:47 ` [PATCH 1/4] iio: ABI: add new DAC powerdown mode Kim Seer Paller
2025-03-19  3:47 ` [PATCH 2/4] iio: dac: ad3530r: Add ABI file for the AD3530R DAC Kim Seer Paller
2025-03-19  3:47 ` [PATCH 3/4] dt-bindings: iio: dac: Add adi,ad3530r.yaml Kim Seer Paller
2025-03-19  5:22   ` Rob Herring (Arm) [this message]
2025-03-19  8:15   ` Krzysztof Kozlowski
2025-03-20  0:52     ` Paller, Kim Seer
2025-03-19  3:47 ` [PATCH 4/4] iio: dac: ad3530r: Add driver for AD3530R and AD3531R Kim Seer Paller
2025-03-20 22:08   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174236176222.620075.12480666866175403765.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=kimseer.paller@analog.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox