From: "Rob Herring (Arm)" <robh@kernel.org>
To: Kim Seer Paller <kimseer.paller@analog.com>
Cc: Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2 3/4] dt-bindings: iio: dac: Add adi,ad3530r.yaml
Date: Mon, 24 Mar 2025 09:21:24 -0500 [thread overview]
Message-ID: <174282608144.6314.4370780992261179576.robh@kernel.org> (raw)
In-Reply-To: <20250324-togreg-v2-3-f211d781923e@analog.com>
On Mon, 24 Mar 2025 19:22:57 +0800, Kim Seer Paller wrote:
> Document the AD3530R/AD3530, an 8-Channel, 16-bit Voltage Output DAC,
> while the AD3531R/AD3531 is a 4-Channel, 16-Bit Voltage Output DAC.
> These devices include software-programmable gain controls that provide
> full-scale output spans of 2.5V or 5V for reference voltages of 2.5V.
> They operate from a single supply voltage range of 2.7V to 5.5V and are
> guaranteed to be monotonic by design. Additionally, these devices
> features a 2.5V, 5ppm/°C internal reference, which is disabled by default.
>
> Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
> ---
> .../devicetree/bindings/iio/dac/adi,ad3530r.yaml | 91 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 92 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.example.dtb: adc@0: pwm-names: ['convst1'] is too short
from schema $id: http://devicetree.org/schemas/iio/adc/adi,ad7606.yaml#
doc reference errors (make refcheckdocs):
Warning: Documentation/arch/powerpc/cxl.rst references a file that doesn't exist: Documentation/ABI/testing/sysfs-class-cxl
Warning: lib/Kconfig.debug references a file that doesn't exist: Documentation/dev-tools/fault-injection/fault-injection.rst
Documentation/arch/powerpc/cxl.rst: Documentation/ABI/testing/sysfs-class-cxl
lib/Kconfig.debug: Documentation/dev-tools/fault-injection/fault-injection.rst
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250324-togreg-v2-3-f211d781923e@analog.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-03-24 14:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 11:22 [PATCH v2 0/4] Add driver for AD3530R and AD3531R DACs Kim Seer Paller
2025-03-24 11:22 ` [PATCH v2 1/4] iio: ABI: add new DAC powerdown mode Kim Seer Paller
2025-03-24 11:22 ` [PATCH v2 2/4] iio: dac: ad3530r: Add ABI file for the AD3530R DAC Kim Seer Paller
2025-03-28 8:58 ` Jonathan Cameron
2025-03-31 1:20 ` Paller, Kim Seer
2025-03-24 11:22 ` [PATCH v2 3/4] dt-bindings: iio: dac: Add adi,ad3530r.yaml Kim Seer Paller
2025-03-24 11:35 ` Krzysztof Kozlowski
2025-03-24 14:21 ` Rob Herring (Arm) [this message]
2025-03-28 9:03 ` Jonathan Cameron
2025-03-31 1:31 ` Paller, Kim Seer
2025-03-31 9:41 ` Jonathan Cameron
2025-03-24 11:22 ` [PATCH v2 4/4] iio: dac: ad3530r: Add driver for AD3530R and AD3531R Kim Seer Paller
2025-03-28 9:23 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174282608144.6314.4370780992261179576.robh@kernel.org \
--to=robh@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kimseer.paller@analog.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox