* [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples
@ 2025-07-24 11:13 Krzysztof Kozlowski
2025-07-24 11:13 ` [PATCH 2/4] dt-bindings: iio: adc: Replace hard-coded GPIO/IRQ flag with a define Krzysztof Kozlowski
` (5 more replies)
0 siblings, 6 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-24 11:13 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Lucas Stankus, Puranjay Mohan,
Dan Robertson, Marcelo Schmitt, Alim Akhtar, Dragos Bogdan,
Jean-Baptiste Maneyrol, Ondřej Jirman, Alexandru Tachici,
Stefan Popa, Linus Walleij, Stephan Gerhold, Ceclan Dumitru,
Alexandru Lazar, Andy Gross, Bjorn Andersson, Matti Vaittinen,
Angelo Compagnucci, Mike Looijmans, David Heidelberg,
Manivannan Sadhasivam, Peter Meerwald-Stadler, Andreas Klinger,
linux-iio, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
Cc: Krzysztof Kozlowski
Drop includes of headers which example code does not use. No functional
impact.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml | 1 -
Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml | 2 --
Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml | 2 --
Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml | 2 --
Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml | 2 --
Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml | 1 -
Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml | 1 -
Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml | 1 -
Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml | 1 -
Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml | 1 -
Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml | 1 -
Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml | 1 -
Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml | 1 -
Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml | 1 -
Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 1 -
.../devicetree/bindings/iio/imu/invensense,icm42600.yaml | 2 --
Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml | 2 --
Documentation/devicetree/bindings/iio/light/st,vl6180.yaml | 1 -
.../bindings/iio/magnetometer/voltafield,af8133j.yaml | 1 -
Documentation/devicetree/bindings/iio/pressure/bmp085.yaml | 1 -
20 files changed, 26 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
index 5887021cc90f..3dc973b98f81 100644
--- a/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
+++ b/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
@@ -37,7 +37,6 @@ unevaluatedProperties: false
examples:
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
spi {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml
index 0c5b64cae965..3a8c69eecfde 100644
--- a/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml
+++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml
@@ -57,7 +57,6 @@ unevaluatedProperties: false
examples:
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
i2c {
#address-cells = <1>;
@@ -73,7 +72,6 @@ examples:
};
};
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
spi {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
index 84d949392012..a23a626bfab6 100644
--- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
+++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
@@ -56,7 +56,6 @@ unevaluatedProperties: false
examples:
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
i2c {
#address-cells = <1>;
@@ -72,7 +71,6 @@ examples:
};
};
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
spi {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
index c07261c71013..f39e2912731f 100644
--- a/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
+++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
@@ -58,7 +58,6 @@ unevaluatedProperties: false
examples:
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
i2c {
#address-cells = <1>;
@@ -74,7 +73,6 @@ examples:
};
};
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
spi {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml
index 62465e36a590..88aa67bf2280 100644
--- a/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml
+++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml
@@ -37,7 +37,6 @@ unevaluatedProperties: false
examples:
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
i2c {
#address-cells = <1>;
@@ -52,7 +51,6 @@ examples:
};
};
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
spi {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
index 457a709b583c..85c9537f1f02 100644
--- a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
+++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
@@ -107,7 +107,6 @@ examples:
};
};
- |
- # include <dt-bindings/interrupt-controller/irq.h>
spi {
#address-cells = <1>;
#size-cells = <0>;
diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml
index 8723a336229e..c5fedcf998f2 100644
--- a/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml
+++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml
@@ -40,7 +40,6 @@ additionalProperties: false
examples:
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
i2c {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml b/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml
index f64d99b35492..53de921768ac 100644
--- a/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml
+++ b/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml
@@ -57,7 +57,6 @@ examples:
};
};
- |
- # include <dt-bindings/interrupt-controller/irq.h>
spi {
#address-cells = <1>;
#size-cells = <0>;
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
index ddec9747436c..705adbe88def 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
@@ -93,7 +93,6 @@ unevaluatedProperties: false
examples:
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
i2c {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
index 21ee319d4675..62d906e24997 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
@@ -379,7 +379,6 @@ unevaluatedProperties: false
examples:
# Example AD7173-8 with external reference connected to REF+/REF-:
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
spi {
diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
index c28db0d635a0..b9dc04b0d307 100644
--- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
@@ -278,7 +278,6 @@ examples:
- |
#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
#include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>
- #include <dt-bindings/interrupt-controller/irq.h>
pmic {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml b/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
index 2a8ad4fdfc6b..f0a1347ba4db 100644
--- a/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
@@ -50,7 +50,6 @@ unevaluatedProperties: false
examples:
- |
- #include <dt-bindings/interrupt-controller/irq.h>
spi {
#address-cells = <1>;
#size-cells = <0>;
diff --git a/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml b/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
index 775eee972b12..044b66a3b00c 100644
--- a/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
@@ -44,7 +44,6 @@ unevaluatedProperties: false
examples:
- |
- #include <dt-bindings/interrupt-controller/irq.h>
spi {
#address-cells = <1>;
#size-cells = <0>;
diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml
index bf5a43a81d59..71f9f9b745cb 100644
--- a/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml
@@ -59,7 +59,6 @@ unevaluatedProperties: false
examples:
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
spi {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
index 4cacc9948726..3a725ece7ec4 100644
--- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
+++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
@@ -44,7 +44,6 @@ unevaluatedProperties: false
examples:
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
spi {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
index d4d4e5c3d856..119e28a833fd 100644
--- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
+++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
@@ -74,7 +74,6 @@ unevaluatedProperties: false
examples:
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
i2c {
#address-cells = <1>;
@@ -91,7 +90,6 @@ examples:
};
};
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
spi {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml b/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml
index 688100b240bc..2930b3386703 100644
--- a/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml
+++ b/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml
@@ -47,7 +47,6 @@ unevaluatedProperties: false
examples:
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
i2c {
#address-cells = <1>;
@@ -63,7 +62,6 @@ examples:
};
};
- |
- #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
spi {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml b/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml
index 27c36ab7990d..8598fb631aac 100644
--- a/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml
+++ b/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml
@@ -32,7 +32,6 @@ required:
examples:
- |
- #include <dt-bindings/interrupt-controller/irq.h>
i2c {
#address-cells = <1>;
#size-cells = <0>;
diff --git a/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml b/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml
index b6ab01a6914a..ed42dc5afb99 100644
--- a/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml
+++ b/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml
@@ -44,7 +44,6 @@ additionalProperties: false
examples:
- |
- #include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/gpio/gpio.h>
i2c {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
index 706b7e24f182..b9ea37317b53 100644
--- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
+++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
@@ -109,7 +109,6 @@ examples:
};
- |
# include <dt-bindings/gpio/gpio.h>
- # include <dt-bindings/interrupt-controller/irq.h>
spi {
#address-cells = <1>;
#size-cells = <0>;
--
2.48.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/4] dt-bindings: iio: adc: Replace hard-coded GPIO/IRQ flag with a define
2025-07-24 11:13 [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples Krzysztof Kozlowski
@ 2025-07-24 11:13 ` Krzysztof Kozlowski
2025-07-25 23:14 ` Rob Herring (Arm)
2025-07-28 6:30 ` Matti Vaittinen
2025-07-24 11:13 ` [PATCH 3/4] dt-bindings: iio: adc: samsung,exynos-adc: Use correct IRQ level in example Krzysztof Kozlowski
` (4 subsequent siblings)
5 siblings, 2 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-24 11:13 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Lucas Stankus, Puranjay Mohan,
Dan Robertson, Marcelo Schmitt, Alim Akhtar, Dragos Bogdan,
Jean-Baptiste Maneyrol, Ondřej Jirman, Alexandru Tachici,
Stefan Popa, Linus Walleij, Stephan Gerhold, Ceclan Dumitru,
Alexandru Lazar, Andy Gross, Bjorn Andersson, Matti Vaittinen,
Angelo Compagnucci, Mike Looijmans, David Heidelberg,
Manivannan Sadhasivam, Peter Meerwald-Stadler, Andreas Klinger,
linux-iio, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
Cc: Krzysztof Kozlowski
For readability use known defines instead of hard-coding GPIO or
interrupt flag.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml | 2 +-
Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml
index ef8d51e74c08..592854766583 100644
--- a/Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml
@@ -63,6 +63,6 @@ examples:
vdd-supply = <&adc_vdd>;
vref-supply = <&adc_vref>;
spi-max-frequency = <1000000>;
- shutdown-gpios = <&gpio 26 1>;
+ shutdown-gpios = <&gpio 26 GPIO_ACTIVE_LOW>;
};
};
diff --git a/Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml b/Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml
index 503285823376..4a8f127de7e3 100644
--- a/Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml
@@ -81,7 +81,7 @@ examples:
reg = <0x10>;
interrupt-parent = <&gpio1>;
- interrupts = <29 8>;
+ interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
vdd-supply = <&dummyreg>;
iovdd-supply = <&dummyreg>;
--
2.48.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 3/4] dt-bindings: iio: adc: samsung,exynos-adc: Use correct IRQ level in example
2025-07-24 11:13 [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples Krzysztof Kozlowski
2025-07-24 11:13 ` [PATCH 2/4] dt-bindings: iio: adc: Replace hard-coded GPIO/IRQ flag with a define Krzysztof Kozlowski
@ 2025-07-24 11:13 ` Krzysztof Kozlowski
2025-07-25 3:34 ` Alim Akhtar
` (2 more replies)
2025-07-24 11:13 ` [PATCH 4/4] dt-bindings: iio: light: Simplify interrupts property in the example Krzysztof Kozlowski
` (3 subsequent siblings)
5 siblings, 3 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-24 11:13 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Lucas Stankus, Puranjay Mohan,
Dan Robertson, Marcelo Schmitt, Alim Akhtar, Dragos Bogdan,
Jean-Baptiste Maneyrol, Ondřej Jirman, Alexandru Tachici,
Stefan Popa, Linus Walleij, Stephan Gerhold, Ceclan Dumitru,
Alexandru Lazar, Andy Gross, Bjorn Andersson, Matti Vaittinen,
Angelo Compagnucci, Mike Looijmans, David Heidelberg,
Manivannan Sadhasivam, Peter Meerwald-Stadler, Andreas Klinger,
linux-iio, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
Cc: Krzysztof Kozlowski
The interrupt line to GIC is IRQ_TYPE_LEVEL_HIGH, so use that instead of
"none". Also replace the hard-coded GIC_SPI flag.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
index 4e40f6bed5db..8069e99ddac8 100644
--- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
@@ -128,10 +128,12 @@ allOf:
examples:
- |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
adc: adc@12d10000 {
compatible = "samsung,exynos-adc-v1";
reg = <0x12d10000 0x100>;
- interrupts = <0 106 0>;
+ interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
#io-channel-cells = <1>;
clocks = <&clock 303>;
@@ -152,11 +154,12 @@ examples:
- |
#include <dt-bindings/clock/exynos3250.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
adc@126c0000 {
compatible = "samsung,exynos3250-adc";
reg = <0x126c0000 0x100>;
- interrupts = <0 137 0>;
+ interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
#io-channel-cells = <1>;
clocks = <&cmu CLK_TSADC>,
--
2.48.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 4/4] dt-bindings: iio: light: Simplify interrupts property in the example
2025-07-24 11:13 [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples Krzysztof Kozlowski
2025-07-24 11:13 ` [PATCH 2/4] dt-bindings: iio: adc: Replace hard-coded GPIO/IRQ flag with a define Krzysztof Kozlowski
2025-07-24 11:13 ` [PATCH 3/4] dt-bindings: iio: adc: samsung,exynos-adc: Use correct IRQ level in example Krzysztof Kozlowski
@ 2025-07-24 11:13 ` Krzysztof Kozlowski
2025-07-24 11:22 ` David Heidelberg
2025-07-25 23:16 ` Rob Herring (Arm)
2025-07-24 11:19 ` [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples David Heidelberg
` (2 subsequent siblings)
5 siblings, 2 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-24 11:13 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Lucas Stankus, Puranjay Mohan,
Dan Robertson, Marcelo Schmitt, Alim Akhtar, Dragos Bogdan,
Jean-Baptiste Maneyrol, Ondřej Jirman, Alexandru Tachici,
Stefan Popa, Linus Walleij, Stephan Gerhold, Ceclan Dumitru,
Alexandru Lazar, Andy Gross, Bjorn Andersson, Matti Vaittinen,
Angelo Compagnucci, Mike Looijmans, David Heidelberg,
Manivannan Sadhasivam, Peter Meerwald-Stadler, Andreas Klinger,
linux-iio, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
Cc: Krzysztof Kozlowski
dynaimage,al3010 and dynaimage,al3320a are I2C devices, so their
interrupts are not routed to GIC and rarely first interrupt cell is <0>.
This looks like copy-paste from some SoC block, so drop it and also for
readability use known defines instead of hard-coding interrupt flag.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/iio/light/dynaimage,al3010.yaml | 2 +-
.../devicetree/bindings/iio/light/dynaimage,al3320a.yaml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml b/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml
index f1048c30e73e..1472c997c16f 100644
--- a/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml
+++ b/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml
@@ -42,6 +42,6 @@ examples:
compatible = "dynaimage,al3010";
reg = <0x1c>;
vdd-supply = <&vdd_reg>;
- interrupts = <0 99 4>;
+ interrupts = <99 IRQ_TYPE_LEVEL_HIGH>;
};
};
diff --git a/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml b/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml
index 8249be99cff9..d06db737cd9e 100644
--- a/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml
+++ b/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml
@@ -40,6 +40,6 @@ examples:
compatible = "dynaimage,al3320a";
reg = <0x1c>;
vdd-supply = <&vdd_reg>;
- interrupts = <0 99 4>;
+ interrupts = <99 IRQ_TYPE_LEVEL_HIGH>;
};
};
--
2.48.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples
2025-07-24 11:13 [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples Krzysztof Kozlowski
` (2 preceding siblings ...)
2025-07-24 11:13 ` [PATCH 4/4] dt-bindings: iio: light: Simplify interrupts property in the example Krzysztof Kozlowski
@ 2025-07-24 11:19 ` David Heidelberg
2025-07-24 11:30 ` Jonathan Cameron
2025-07-25 23:14 ` Rob Herring (Arm)
2025-07-28 6:33 ` Matti Vaittinen
5 siblings, 1 reply; 16+ messages in thread
From: David Heidelberg @ 2025-07-24 11:19 UTC (permalink / raw)
To: Krzysztof Kozlowski, Lars-Peter Clausen, Michael Hennerich,
Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Lucas Stankus,
Puranjay Mohan, Dan Robertson, Marcelo Schmitt, Alim Akhtar,
Dragos Bogdan, Jean-Baptiste Maneyrol, Ondřej Jirman,
Alexandru Tachici, Stefan Popa, Linus Walleij, Stephan Gerhold,
Ceclan Dumitru, Alexandru Lazar, Andy Gross, Bjorn Andersson,
Matti Vaittinen, Angelo Compagnucci, Mike Looijmans,
Manivannan Sadhasivam, Peter Meerwald-Stadler, Andreas Klinger,
linux-iio, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
Reviewed-by: David Heidelberg <david@ixit.cz>
On 24/07/2025 13:13, Krzysztof Kozlowski wrote:
> Drop includes of headers which example code does not use. No functional
> impact.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml | 1 -
> Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml | 2 --
> Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml | 2 --
> Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml | 2 --
> Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml | 2 --
> Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml | 1 -
> Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml | 1 -
> Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml | 1 -
> Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 1 -
> .../devicetree/bindings/iio/imu/invensense,icm42600.yaml | 2 --
> Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml | 2 --
> Documentation/devicetree/bindings/iio/light/st,vl6180.yaml | 1 -
> .../bindings/iio/magnetometer/voltafield,af8133j.yaml | 1 -
> Documentation/devicetree/bindings/iio/pressure/bmp085.yaml | 1 -
> 20 files changed, 26 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
> index 5887021cc90f..3dc973b98f81 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
> @@ -37,7 +37,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml
> index 0c5b64cae965..3a8c69eecfde 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml
> @@ -57,7 +57,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> @@ -73,7 +72,6 @@ examples:
> };
> };
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> index 84d949392012..a23a626bfab6 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> @@ -56,7 +56,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> @@ -72,7 +71,6 @@ examples:
> };
> };
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
> index c07261c71013..f39e2912731f 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
> @@ -58,7 +58,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> @@ -74,7 +73,6 @@ examples:
> };
> };
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml
> index 62465e36a590..88aa67bf2280 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml
> @@ -37,7 +37,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> @@ -52,7 +51,6 @@ examples:
> };
> };
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> index 457a709b583c..85c9537f1f02 100644
> --- a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> @@ -107,7 +107,6 @@ examples:
> };
> };
> - |
> - # include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml
> index 8723a336229e..c5fedcf998f2 100644
> --- a/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml
> @@ -40,7 +40,6 @@ additionalProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml b/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml
> index f64d99b35492..53de921768ac 100644
> --- a/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml
> @@ -57,7 +57,6 @@ examples:
> };
> };
> - |
> - # include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
> index ddec9747436c..705adbe88def 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
> @@ -93,7 +93,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> index 21ee319d4675..62d906e24997 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> @@ -379,7 +379,6 @@ unevaluatedProperties: false
> examples:
> # Example AD7173-8 with external reference connected to REF+/REF-:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
>
> spi {
> diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
> index c28db0d635a0..b9dc04b0d307 100644
> --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
> @@ -278,7 +278,6 @@ examples:
> - |
> #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
> #include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>
> - #include <dt-bindings/interrupt-controller/irq.h>
>
> pmic {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml b/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
> index 2a8ad4fdfc6b..f0a1347ba4db 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
> @@ -50,7 +50,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml b/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
> index 775eee972b12..044b66a3b00c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
> @@ -44,7 +44,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml
> index bf5a43a81d59..71f9f9b745cb 100644
> --- a/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml
> @@ -59,7 +59,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> index 4cacc9948726..3a725ece7ec4 100644
> --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> @@ -44,7 +44,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> index d4d4e5c3d856..119e28a833fd 100644
> --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> @@ -74,7 +74,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> @@ -91,7 +90,6 @@ examples:
> };
> };
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml b/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml
> index 688100b240bc..2930b3386703 100644
> --- a/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml
> @@ -47,7 +47,6 @@ unevaluatedProperties: false
>
> examples:
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> @@ -63,7 +62,6 @@ examples:
> };
> };
> - |
> - #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml b/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml
> index 27c36ab7990d..8598fb631aac 100644
> --- a/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml
> @@ -32,7 +32,6 @@ required:
>
> examples:
> - |
> - #include <dt-bindings/interrupt-controller/irq.h>
> i2c {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml b/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml
> index b6ab01a6914a..ed42dc5afb99 100644
> --- a/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml
> @@ -44,7 +44,6 @@ additionalProperties: false
>
> examples:
> - |
> - #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/gpio/gpio.h>
> i2c {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> index 706b7e24f182..b9ea37317b53 100644
> --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> @@ -109,7 +109,6 @@ examples:
> };
> - |
> # include <dt-bindings/gpio/gpio.h>
> - # include <dt-bindings/interrupt-controller/irq.h>
> spi {
> #address-cells = <1>;
> #size-cells = <0>;
--
David Heidelberg
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 4/4] dt-bindings: iio: light: Simplify interrupts property in the example
2025-07-24 11:13 ` [PATCH 4/4] dt-bindings: iio: light: Simplify interrupts property in the example Krzysztof Kozlowski
@ 2025-07-24 11:22 ` David Heidelberg
2025-07-25 23:16 ` Rob Herring (Arm)
1 sibling, 0 replies; 16+ messages in thread
From: David Heidelberg @ 2025-07-24 11:22 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski
Cc: Lars-Peter Clausen, Andy Shevchenko, Ceclan Dumitru,
Michael Hennerich, Conor Dooley, devicetree, Alexandru Lazar,
linux-arm-kernel, Bjorn Andersson, Stephan Gerhold,
Jean-Baptiste Maneyrol, Angelo Compagnucci, Marcelo Schmitt,
Ondřej Jirman, David Lechner, linux-iio, Matti Vaittinen,
Mike Looijmans, Puranjay Mohan, Manivannan Sadhasivam,
Peter Meerwald-Stadler, linux-samsung-soc, Alim Akhtar,
Dan Robertson, Linus Walleij, Stefan Popa, Dragos Bogdan,
Alexandru Tachici, Nuno Sá, Jonathan Cameron, Lucas Stankus,
linux-kernel, Andreas Klinger, Andy Gross
Thank you,
Reviewed-by: David Heidelberg <david@ixit.cz>
On 24/07/2025 13:13, Krzysztof Kozlowski wrote:
> dynaimage,al3010 and dynaimage,al3320a are I2C devices, so their
> interrupts are not routed to GIC and rarely first interrupt cell is <0>.
> This looks like copy-paste from some SoC block, so drop it and also for
> readability use known defines instead of hard-coding interrupt flag.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/iio/light/dynaimage,al3010.yaml | 2 +-
> .../devicetree/bindings/iio/light/dynaimage,al3320a.yaml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml b/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml
> index f1048c30e73e..1472c997c16f 100644
> --- a/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml
> @@ -42,6 +42,6 @@ examples:
> compatible = "dynaimage,al3010";
> reg = <0x1c>;
> vdd-supply = <&vdd_reg>;
> - interrupts = <0 99 4>;
> + interrupts = <99 IRQ_TYPE_LEVEL_HIGH>;
> };
> };
> diff --git a/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml b/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml
> index 8249be99cff9..d06db737cd9e 100644
> --- a/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml
> @@ -40,6 +40,6 @@ examples:
> compatible = "dynaimage,al3320a";
> reg = <0x1c>;
> vdd-supply = <&vdd_reg>;
> - interrupts = <0 99 4>;
> + interrupts = <99 IRQ_TYPE_LEVEL_HIGH>;
> };
> };
--
David Heidelberg
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples
2025-07-24 11:19 ` [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples David Heidelberg
@ 2025-07-24 11:30 ` Jonathan Cameron
0 siblings, 0 replies; 16+ messages in thread
From: Jonathan Cameron @ 2025-07-24 11:30 UTC (permalink / raw)
To: David Heidelberg
Cc: Krzysztof Kozlowski, Lars-Peter Clausen, Michael Hennerich,
David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Lucas Stankus, Puranjay Mohan,
Dan Robertson, Marcelo Schmitt, Alim Akhtar, Dragos Bogdan,
Jean-Baptiste Maneyrol, Ondřej Jirman, Alexandru Tachici,
Stefan Popa, Linus Walleij, Stephan Gerhold, Ceclan Dumitru,
Alexandru Lazar, Andy Gross, Bjorn Andersson, Matti Vaittinen,
Angelo Compagnucci, Mike Looijmans, Manivannan Sadhasivam,
Peter Meerwald-Stadler, Andreas Klinger, linux-iio, devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc
On Thu, 24 Jul 2025 13:19:58 +0200
David Heidelberg <david@ixit.cz> wrote:
> Reviewed-by: David Heidelberg <david@ixit.cz>
I'm going to take the view these are utterly uncontroversial and pick them
up now (I'm trying to clear my review backlog).
Applied to the testing branch of iio.git which will be rebased on rc1
(so I can easily add tags etc)
Jonathan
>
> On 24/07/2025 13:13, Krzysztof Kozlowski wrote:
> > Drop includes of headers which example code does not use. No functional
> > impact.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml | 1 -
> > Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml | 2 --
> > Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml | 2 --
> > Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml | 2 --
> > Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml | 2 --
> > Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml | 1 -
> > Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml | 1 -
> > Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml | 1 -
> > Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml | 1 -
> > Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml | 1 -
> > Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml | 1 -
> > Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml | 1 -
> > Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml | 1 -
> > Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml | 1 -
> > Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 1 -
> > .../devicetree/bindings/iio/imu/invensense,icm42600.yaml | 2 --
> > Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml | 2 --
> > Documentation/devicetree/bindings/iio/light/st,vl6180.yaml | 1 -
> > .../bindings/iio/magnetometer/voltafield,af8133j.yaml | 1 -
> > Documentation/devicetree/bindings/iio/pressure/bmp085.yaml | 1 -
> > 20 files changed, 26 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
> > index 5887021cc90f..3dc973b98f81 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
> > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
> > @@ -37,7 +37,6 @@ unevaluatedProperties: false
> >
> > examples:
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > spi {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml
> > index 0c5b64cae965..3a8c69eecfde 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml
> > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml
> > @@ -57,7 +57,6 @@ unevaluatedProperties: false
> >
> > examples:
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > i2c {
> > #address-cells = <1>;
> > @@ -73,7 +72,6 @@ examples:
> > };
> > };
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > spi {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> > index 84d949392012..a23a626bfab6 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> > @@ -56,7 +56,6 @@ unevaluatedProperties: false
> >
> > examples:
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > i2c {
> > #address-cells = <1>;
> > @@ -72,7 +71,6 @@ examples:
> > };
> > };
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > spi {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
> > index c07261c71013..f39e2912731f 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
> > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
> > @@ -58,7 +58,6 @@ unevaluatedProperties: false
> >
> > examples:
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > i2c {
> > #address-cells = <1>;
> > @@ -74,7 +73,6 @@ examples:
> > };
> > };
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > spi {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml
> > index 62465e36a590..88aa67bf2280 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml
> > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml
> > @@ -37,7 +37,6 @@ unevaluatedProperties: false
> >
> > examples:
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > i2c {
> > #address-cells = <1>;
> > @@ -52,7 +51,6 @@ examples:
> > };
> > };
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > spi {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> > index 457a709b583c..85c9537f1f02 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> > +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> > @@ -107,7 +107,6 @@ examples:
> > };
> > };
> > - |
> > - # include <dt-bindings/interrupt-controller/irq.h>
> > spi {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml
> > index 8723a336229e..c5fedcf998f2 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml
> > +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml
> > @@ -40,7 +40,6 @@ additionalProperties: false
> >
> > examples:
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > i2c {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml b/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml
> > index f64d99b35492..53de921768ac 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml
> > +++ b/Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml
> > @@ -57,7 +57,6 @@ examples:
> > };
> > };
> > - |
> > - # include <dt-bindings/interrupt-controller/irq.h>
> > spi {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
> > index ddec9747436c..705adbe88def 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
> > @@ -93,7 +93,6 @@ unevaluatedProperties: false
> >
> > examples:
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > i2c {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> > index 21ee319d4675..62d906e24997 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> > @@ -379,7 +379,6 @@ unevaluatedProperties: false
> > examples:
> > # Example AD7173-8 with external reference connected to REF+/REF-:
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> >
> > spi {
> > diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
> > index c28db0d635a0..b9dc04b0d307 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
> > @@ -278,7 +278,6 @@ examples:
> > - |
> > #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
> > #include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>
> > - #include <dt-bindings/interrupt-controller/irq.h>
> >
> > pmic {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml b/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
> > index 2a8ad4fdfc6b..f0a1347ba4db 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
> > @@ -50,7 +50,6 @@ unevaluatedProperties: false
> >
> > examples:
> > - |
> > - #include <dt-bindings/interrupt-controller/irq.h>
> > spi {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml b/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
> > index 775eee972b12..044b66a3b00c 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
> > @@ -44,7 +44,6 @@ unevaluatedProperties: false
> >
> > examples:
> > - |
> > - #include <dt-bindings/interrupt-controller/irq.h>
> > spi {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml
> > index bf5a43a81d59..71f9f9b745cb 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml
> > @@ -59,7 +59,6 @@ unevaluatedProperties: false
> >
> > examples:
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > spi {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > index 4cacc9948726..3a725ece7ec4 100644
> > --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > @@ -44,7 +44,6 @@ unevaluatedProperties: false
> >
> > examples:
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > spi {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> > index d4d4e5c3d856..119e28a833fd 100644
> > --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> > +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> > @@ -74,7 +74,6 @@ unevaluatedProperties: false
> >
> > examples:
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > i2c {
> > #address-cells = <1>;
> > @@ -91,7 +90,6 @@ examples:
> > };
> > };
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > spi {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml b/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml
> > index 688100b240bc..2930b3386703 100644
> > --- a/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml
> > +++ b/Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml
> > @@ -47,7 +47,6 @@ unevaluatedProperties: false
> >
> > examples:
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > i2c {
> > #address-cells = <1>;
> > @@ -63,7 +62,6 @@ examples:
> > };
> > };
> > - |
> > - #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > spi {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml b/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml
> > index 27c36ab7990d..8598fb631aac 100644
> > --- a/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml
> > +++ b/Documentation/devicetree/bindings/iio/light/st,vl6180.yaml
> > @@ -32,7 +32,6 @@ required:
> >
> > examples:
> > - |
> > - #include <dt-bindings/interrupt-controller/irq.h>
> > i2c {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml b/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml
> > index b6ab01a6914a..ed42dc5afb99 100644
> > --- a/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml
> > +++ b/Documentation/devicetree/bindings/iio/magnetometer/voltafield,af8133j.yaml
> > @@ -44,7 +44,6 @@ additionalProperties: false
> >
> > examples:
> > - |
> > - #include <dt-bindings/interrupt-controller/irq.h>
> > #include <dt-bindings/gpio/gpio.h>
> > i2c {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> > index 706b7e24f182..b9ea37317b53 100644
> > --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> > +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> > @@ -109,7 +109,6 @@ examples:
> > };
> > - |
> > # include <dt-bindings/gpio/gpio.h>
> > - # include <dt-bindings/interrupt-controller/irq.h>
> > spi {
> > #address-cells = <1>;
> > #size-cells = <0>;
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH 3/4] dt-bindings: iio: adc: samsung,exynos-adc: Use correct IRQ level in example
2025-07-24 11:13 ` [PATCH 3/4] dt-bindings: iio: adc: samsung,exynos-adc: Use correct IRQ level in example Krzysztof Kozlowski
@ 2025-07-25 3:34 ` Alim Akhtar
2025-07-25 4:34 ` Sam Protsenko
2025-07-25 23:15 ` Rob Herring (Arm)
2 siblings, 0 replies; 16+ messages in thread
From: Alim Akhtar @ 2025-07-25 3:34 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lars-Peter Clausen',
'Michael Hennerich', 'Jonathan Cameron',
'David Lechner', 'Nuno Sá',
'Andy Shevchenko', 'Rob Herring',
'Krzysztof Kozlowski', 'Conor Dooley',
'Lucas Stankus', 'Puranjay Mohan',
'Dan Robertson', 'Marcelo Schmitt',
'Dragos Bogdan', 'Jean-Baptiste Maneyrol',
'Ondřej Jirman', 'Alexandru Tachici',
'Stefan Popa', 'Linus Walleij',
'Stephan Gerhold', 'Ceclan Dumitru',
'Alexandru Lazar', 'Andy Gross',
'Bjorn Andersson', 'Matti Vaittinen',
'Angelo Compagnucci', 'Mike Looijmans',
'David Heidelberg', 'Manivannan Sadhasivam',
'Peter Meerwald-Stadler', 'Andreas Klinger',
linux-iio, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Thursday, July 24, 2025 4:44 PM
> To: Lars-Peter Clausen <lars@metafoo.de>; Michael Hennerich
> <Michael.Hennerich@analog.com>; Jonathan Cameron <jic23@kernel.org>;
> David Lechner <dlechner@baylibre.com>; Nuno Sá <nuno.sa@analog.com>;
> Andy Shevchenko <andy@kernel.org>; Rob Herring <robh@kernel.org>;
.
.
.
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 3/4] dt-bindings: iio: adc: samsung,exynos-adc: Use correct
> IRQ level in example
>
> The interrupt line to GIC is IRQ_TYPE_LEVEL_HIGH, so use that instead of
> "none". Also replace the hard-coded GIC_SPI flag.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/4] dt-bindings: iio: adc: samsung,exynos-adc: Use correct IRQ level in example
2025-07-24 11:13 ` [PATCH 3/4] dt-bindings: iio: adc: samsung,exynos-adc: Use correct IRQ level in example Krzysztof Kozlowski
2025-07-25 3:34 ` Alim Akhtar
@ 2025-07-25 4:34 ` Sam Protsenko
2025-07-25 23:15 ` Rob Herring (Arm)
2 siblings, 0 replies; 16+ messages in thread
From: Sam Protsenko @ 2025-07-25 4:34 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Lucas Stankus, Puranjay Mohan,
Dan Robertson, Marcelo Schmitt, Alim Akhtar, Dragos Bogdan,
Jean-Baptiste Maneyrol, Ondřej Jirman, Alexandru Tachici,
Stefan Popa, Linus Walleij, Stephan Gerhold, Ceclan Dumitru,
Alexandru Lazar, Andy Gross, Bjorn Andersson, Matti Vaittinen,
Angelo Compagnucci, Mike Looijmans, David Heidelberg,
Manivannan Sadhasivam, Peter Meerwald-Stadler, Andreas Klinger,
linux-iio, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
On Thu, Jul 24, 2025 at 6:14 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> The interrupt line to GIC is IRQ_TYPE_LEVEL_HIGH, so use that instead of
> "none". Also replace the hard-coded GIC_SPI flag.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index 4e40f6bed5db..8069e99ddac8 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -128,10 +128,12 @@ allOf:
>
> examples:
> - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> adc: adc@12d10000 {
> compatible = "samsung,exynos-adc-v1";
> reg = <0x12d10000 0x100>;
> - interrupts = <0 106 0>;
> + interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
> #io-channel-cells = <1>;
>
> clocks = <&clock 303>;
> @@ -152,11 +154,12 @@ examples:
>
> - |
> #include <dt-bindings/clock/exynos3250.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> adc@126c0000 {
> compatible = "samsung,exynos3250-adc";
> reg = <0x126c0000 0x100>;
> - interrupts = <0 137 0>;
> + interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
> #io-channel-cells = <1>;
>
> clocks = <&cmu CLK_TSADC>,
> --
> 2.48.1
>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples
2025-07-24 11:13 [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples Krzysztof Kozlowski
` (3 preceding siblings ...)
2025-07-24 11:19 ` [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples David Heidelberg
@ 2025-07-25 23:14 ` Rob Herring (Arm)
2025-07-28 6:33 ` Matti Vaittinen
5 siblings, 0 replies; 16+ messages in thread
From: Rob Herring (Arm) @ 2025-07-25 23:14 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, Manivannan Sadhasivam, Jonathan Cameron,
Ceclan Dumitru, David Lechner, Stefan Popa, linux-iio,
Michael Hennerich, David Heidelberg, Nuno Sá,
Andreas Klinger, linux-arm-kernel, Bjorn Andersson, Lucas Stankus,
Andy Gross, Alexandru Lazar, Puranjay Mohan, devicetree,
Stephan Gerhold, Alexandru Tachici, Conor Dooley,
Jean-Baptiste Maneyrol, Mike Looijmans, Matti Vaittinen,
Marcelo Schmitt, Angelo Compagnucci, Lars-Peter Clausen,
linux-samsung-soc, Alim Akhtar, Dragos Bogdan, linux-kernel,
Peter Meerwald-Stadler, Dan Robertson, Ondřej Jirman,
Andy Shevchenko, Linus Walleij
On Thu, 24 Jul 2025 13:13:46 +0200, Krzysztof Kozlowski wrote:
> Drop includes of headers which example code does not use. No functional
> impact.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml | 1 -
> Documentation/devicetree/bindings/iio/accel/adi,adxl313.yaml | 2 --
> Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml | 2 --
> Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml | 2 --
> Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml | 2 --
> Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml | 1 -
> Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml | 1 -
> Documentation/devicetree/bindings/iio/accel/kionix,kxsd9.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml | 1 -
> Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml | 1 -
> Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 1 -
> .../devicetree/bindings/iio/imu/invensense,icm42600.yaml | 2 --
> Documentation/devicetree/bindings/iio/imu/nxp,fxos8700.yaml | 2 --
> Documentation/devicetree/bindings/iio/light/st,vl6180.yaml | 1 -
> .../bindings/iio/magnetometer/voltafield,af8133j.yaml | 1 -
> Documentation/devicetree/bindings/iio/pressure/bmp085.yaml | 1 -
> 20 files changed, 26 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/4] dt-bindings: iio: adc: Replace hard-coded GPIO/IRQ flag with a define
2025-07-24 11:13 ` [PATCH 2/4] dt-bindings: iio: adc: Replace hard-coded GPIO/IRQ flag with a define Krzysztof Kozlowski
@ 2025-07-25 23:14 ` Rob Herring (Arm)
2025-07-28 6:30 ` Matti Vaittinen
1 sibling, 0 replies; 16+ messages in thread
From: Rob Herring (Arm) @ 2025-07-25 23:14 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-kernel, Angelo Compagnucci, Nuno Sá,
Jonathan Cameron, Andreas Klinger, Dan Robertson, Lucas Stankus,
Alexandru Lazar, linux-samsung-soc, Peter Meerwald-Stadler,
Krzysztof Kozlowski, David Heidelberg, Jean-Baptiste Maneyrol,
Conor Dooley, devicetree, linux-iio, Puranjay Mohan,
Ondřej Jirman, Alexandru Tachici, Matti Vaittinen,
David Lechner, Marcelo Schmitt, Stephan Gerhold, Andy Shevchenko,
Stefan Popa, Lars-Peter Clausen, Ceclan Dumitru,
Michael Hennerich, Mike Looijmans, Bjorn Andersson, linux-kernel,
Andy Gross, Alim Akhtar, Linus Walleij, Dragos Bogdan,
Manivannan Sadhasivam
On Thu, 24 Jul 2025 13:13:47 +0200, Krzysztof Kozlowski wrote:
> For readability use known defines instead of hard-coding GPIO or
> interrupt flag.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml | 2 +-
> Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/4] dt-bindings: iio: adc: samsung,exynos-adc: Use correct IRQ level in example
2025-07-24 11:13 ` [PATCH 3/4] dt-bindings: iio: adc: samsung,exynos-adc: Use correct IRQ level in example Krzysztof Kozlowski
2025-07-25 3:34 ` Alim Akhtar
2025-07-25 4:34 ` Sam Protsenko
@ 2025-07-25 23:15 ` Rob Herring (Arm)
2 siblings, 0 replies; 16+ messages in thread
From: Rob Herring (Arm) @ 2025-07-25 23:15 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-samsung-soc, Bjorn Andersson, Puranjay Mohan,
Jonathan Cameron, Dan Robertson, Ondřej Jirman,
Angelo Compagnucci, Krzysztof Kozlowski, Linus Walleij,
Manivannan Sadhasivam, Lars-Peter Clausen, Alexandru Lazar,
Alexandru Tachici, linux-iio, Lucas Stankus, Mike Looijmans,
David Lechner, Stefan Popa, Michael Hennerich,
Jean-Baptiste Maneyrol, Ceclan Dumitru, Dragos Bogdan,
Nuno Sá, Andy Gross, Peter Meerwald-Stadler, Conor Dooley,
linux-arm-kernel, Matti Vaittinen, Andreas Klinger,
Andy Shevchenko, devicetree, Marcelo Schmitt, Alim Akhtar,
Stephan Gerhold, David Heidelberg, linux-kernel
On Thu, 24 Jul 2025 13:13:48 +0200, Krzysztof Kozlowski wrote:
> The interrupt line to GIC is IRQ_TYPE_LEVEL_HIGH, so use that instead of
> "none". Also replace the hard-coded GIC_SPI flag.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 4/4] dt-bindings: iio: light: Simplify interrupts property in the example
2025-07-24 11:13 ` [PATCH 4/4] dt-bindings: iio: light: Simplify interrupts property in the example Krzysztof Kozlowski
2025-07-24 11:22 ` David Heidelberg
@ 2025-07-25 23:16 ` Rob Herring (Arm)
1 sibling, 0 replies; 16+ messages in thread
From: Rob Herring (Arm) @ 2025-07-25 23:16 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Puranjay Mohan, Matti Vaittinen, Angelo Compagnucci, devicetree,
Mike Looijmans, Andreas Klinger, linux-kernel, linux-arm-kernel,
Ceclan Dumitru, Nuno Sá, Dragos Bogdan,
Peter Meerwald-Stadler, Andy Shevchenko, David Lechner,
Bjorn Andersson, Manivannan Sadhasivam, Linus Walleij,
Krzysztof Kozlowski, Alexandru Lazar, Alim Akhtar,
Stephan Gerhold, Marcelo Schmitt, Conor Dooley, linux-samsung-soc,
Jonathan Cameron, Alexandru Tachici, David Heidelberg, Andy Gross,
Michael Hennerich, Jean-Baptiste Maneyrol, linux-iio, Stefan Popa,
Lucas Stankus, Ondřej Jirman, Dan Robertson,
Lars-Peter Clausen
On Thu, 24 Jul 2025 13:13:49 +0200, Krzysztof Kozlowski wrote:
> dynaimage,al3010 and dynaimage,al3320a are I2C devices, so their
> interrupts are not routed to GIC and rarely first interrupt cell is <0>.
> This looks like copy-paste from some SoC block, so drop it and also for
> readability use known defines instead of hard-coding interrupt flag.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/iio/light/dynaimage,al3010.yaml | 2 +-
> .../devicetree/bindings/iio/light/dynaimage,al3320a.yaml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/4] dt-bindings: iio: adc: Replace hard-coded GPIO/IRQ flag with a define
2025-07-24 11:13 ` [PATCH 2/4] dt-bindings: iio: adc: Replace hard-coded GPIO/IRQ flag with a define Krzysztof Kozlowski
2025-07-25 23:14 ` Rob Herring (Arm)
@ 2025-07-28 6:30 ` Matti Vaittinen
1 sibling, 0 replies; 16+ messages in thread
From: Matti Vaittinen @ 2025-07-28 6:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, Lars-Peter Clausen, Michael Hennerich,
Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Lucas Stankus,
Puranjay Mohan, Dan Robertson, Marcelo Schmitt, Alim Akhtar,
Dragos Bogdan, Jean-Baptiste Maneyrol, Ondřej Jirman,
Alexandru Tachici, Stefan Popa, Linus Walleij, Stephan Gerhold,
Ceclan Dumitru, Alexandru Lazar, Andy Gross, Bjorn Andersson,
Angelo Compagnucci, Mike Looijmans, David Heidelberg,
Manivannan Sadhasivam, Peter Meerwald-Stadler, Andreas Klinger,
linux-iio, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
On 24/07/2025 14:13, Krzysztof Kozlowski wrote:
> For readability use known defines instead of hard-coding GPIO or
> interrupt flag.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
FWIW:
Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>
Thanks!
> ---
> Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml | 2 +-
> Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml
> index ef8d51e74c08..592854766583 100644
> --- a/Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml
> @@ -63,6 +63,6 @@ examples:
> vdd-supply = <&adc_vdd>;
> vref-supply = <&adc_vref>;
> spi-max-frequency = <1000000>;
> - shutdown-gpios = <&gpio 26 1>;
> + shutdown-gpios = <&gpio 26 GPIO_ACTIVE_LOW>;
> };
> };
> diff --git a/Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml b/Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml
> index 503285823376..4a8f127de7e3 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml
> @@ -81,7 +81,7 @@ examples:
> reg = <0x10>;
>
> interrupt-parent = <&gpio1>;
> - interrupts = <29 8>;
> + interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
>
> vdd-supply = <&dummyreg>;
> iovdd-supply = <&dummyreg>;
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples
2025-07-24 11:13 [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples Krzysztof Kozlowski
` (4 preceding siblings ...)
2025-07-25 23:14 ` Rob Herring (Arm)
@ 2025-07-28 6:33 ` Matti Vaittinen
2025-07-28 13:47 ` Jonathan Cameron
5 siblings, 1 reply; 16+ messages in thread
From: Matti Vaittinen @ 2025-07-28 6:33 UTC (permalink / raw)
To: Krzysztof Kozlowski, Lars-Peter Clausen, Michael Hennerich,
Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Lucas Stankus,
Puranjay Mohan, Dan Robertson, Marcelo Schmitt, Alim Akhtar,
Dragos Bogdan, Jean-Baptiste Maneyrol, Ondřej Jirman,
Alexandru Tachici, Stefan Popa, Linus Walleij, Stephan Gerhold,
Ceclan Dumitru, Alexandru Lazar, Andy Gross, Bjorn Andersson,
Angelo Compagnucci, Mike Looijmans, David Heidelberg,
Manivannan Sadhasivam, Peter Meerwald-Stadler, Andreas Klinger,
linux-iio, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
On 24/07/2025 14:13, Krzysztof Kozlowski wrote:
> Drop includes of headers which example code does not use. No functional
> impact.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
FWIW:
Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples
2025-07-28 6:33 ` Matti Vaittinen
@ 2025-07-28 13:47 ` Jonathan Cameron
0 siblings, 0 replies; 16+ messages in thread
From: Jonathan Cameron @ 2025-07-28 13:47 UTC (permalink / raw)
To: Matti Vaittinen
Cc: Krzysztof Kozlowski, Lars-Peter Clausen, Michael Hennerich,
David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Lucas Stankus, Puranjay Mohan,
Dan Robertson, Marcelo Schmitt, Alim Akhtar, Dragos Bogdan,
Jean-Baptiste Maneyrol, Ondřej Jirman, Alexandru Tachici,
Stefan Popa, Linus Walleij, Stephan Gerhold, Ceclan Dumitru,
Alexandru Lazar, Andy Gross, Bjorn Andersson, Angelo Compagnucci,
Mike Looijmans, David Heidelberg, Manivannan Sadhasivam,
Peter Meerwald-Stadler, Andreas Klinger, linux-iio, devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc
On Mon, 28 Jul 2025 09:33:37 +0300
Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> On 24/07/2025 14:13, Krzysztof Kozlowski wrote:
> > Drop includes of headers which example code does not use. No functional
> > impact.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> FWIW:
> Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>
>
>
Updated and fresh testing tree pushed out. Thanks
J
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2025-07-28 13:47 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-24 11:13 [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples Krzysztof Kozlowski
2025-07-24 11:13 ` [PATCH 2/4] dt-bindings: iio: adc: Replace hard-coded GPIO/IRQ flag with a define Krzysztof Kozlowski
2025-07-25 23:14 ` Rob Herring (Arm)
2025-07-28 6:30 ` Matti Vaittinen
2025-07-24 11:13 ` [PATCH 3/4] dt-bindings: iio: adc: samsung,exynos-adc: Use correct IRQ level in example Krzysztof Kozlowski
2025-07-25 3:34 ` Alim Akhtar
2025-07-25 4:34 ` Sam Protsenko
2025-07-25 23:15 ` Rob Herring (Arm)
2025-07-24 11:13 ` [PATCH 4/4] dt-bindings: iio: light: Simplify interrupts property in the example Krzysztof Kozlowski
2025-07-24 11:22 ` David Heidelberg
2025-07-25 23:16 ` Rob Herring (Arm)
2025-07-24 11:19 ` [PATCH 1/4] dt-bindings: iio: Drop unused header includes in examples David Heidelberg
2025-07-24 11:30 ` Jonathan Cameron
2025-07-25 23:14 ` Rob Herring (Arm)
2025-07-28 6:33 ` Matti Vaittinen
2025-07-28 13:47 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).