From: Jonathan Cameron <jic23@kernel.org>
To: rishabh hardas <rishabheudyptula@gmail.com>, pmeerw@pmeerw.net
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio:trigger: Fix coding style in iio-trig-bfin-timer.c by removing a waring flagged by checkpatch.pl
Date: Sat, 7 Jan 2017 12:02:48 -0500 [thread overview]
Message-ID: <18ef4ca5-9ad1-41b7-713e-fb8c52e1f7e3@kernel.org> (raw)
In-Reply-To: <22695534-79ba-2e0d-648d-392889f6c03c@kernel.org>
On 07/01/17 11:59, Jonathan Cameron wrote:
> On 07/01/17 05:51, rishabh hardas wrote:
>> Signed-off-by: rishabh hardas <rishabheudyptula@gmail.com>
> Ideally you'd have had a bit more description above the sign off and perhaps a shorter title.
> I'd have left the 'how' element of the patch to this extra description and not put it in the title.
>
> Also, minor typo waring-> warning.
>
> I'll fix that up.
>
> Applied to the togreg branch of iio.git and pushed out as testing
> from the pharma cleanroomwhere I have surprisingly good internet
> access!
Or not pushed out as something is blocking my connection. Might be a day or two
before I get on a sensible connection!
Jonathan
> Jonathan
>> ---
>> drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
>> index 38dca69..9658f20 100644
>> --- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
>> +++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
>> @@ -133,7 +133,7 @@ static ssize_t iio_bfin_tmr_frequency_show(struct device *dev,
>> return sprintf(buf, "%lu\n", val);
>> }
>>
>> -static DEVICE_ATTR(frequency, S_IRUGO | S_IWUSR, iio_bfin_tmr_frequency_show,
>> +static DEVICE_ATTR(frequency, 0644, iio_bfin_tmr_frequency_show,
>> iio_bfin_tmr_frequency_store);
>>
>> static struct attribute *iio_bfin_tmr_trigger_attrs[] = {
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2017-01-07 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAEnQRZCgiUXEZX8iwJV3MU00KoywaPsNFy32QkuEGRui_itgJw>
2017-01-07 10:51 ` [PATCH] iio:trigger: Fix coding style in iio-trig-bfin-timer.c by removing a waring flagged by checkpatch.pl rishabh hardas
2017-01-07 16:59 ` Jonathan Cameron
2017-01-07 17:02 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18ef4ca5-9ad1-41b7-713e-fb8c52e1f7e3@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rishabheudyptula@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).