[PATCH] iio:trigger: Fix coding style in iio-trig-bfin-timer.c by removing a waring flagged by checkpatch.pl

[PATCH] iio:trigger: Fix coding style in iio-trig-bfin-timer.c by removing a waring flagged by checkpatch.pl

[rishabh hardas]

Signed-off-by: rishabh hardas <rishabheudyptula@gmail.com>
---
 drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
index 38dca69..9658f20 100644
--- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
+++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
@@ -133,7 +133,7 @@ static ssize_t iio_bfin_tmr_frequency_show(struct device *dev,
 	return sprintf(buf, "%lu\n", val);
 }
 
-static DEVICE_ATTR(frequency, S_IRUGO | S_IWUSR, iio_bfin_tmr_frequency_show,
+static DEVICE_ATTR(frequency, 0644, iio_bfin_tmr_frequency_show,
 		   iio_bfin_tmr_frequency_store);
 
 static struct attribute *iio_bfin_tmr_trigger_attrs[] = {
-- 
2.7.4

Re: [PATCH] iio:trigger: Fix coding style in iio-trig-bfin-timer.c by removing a waring flagged by checkpatch.pl

[Jonathan Cameron]

On 07/01/17 05:51, rishabh hardas wrote:
> Signed-off-by: rishabh hardas <rishabheudyptula@gmail.com>
Ideally you'd have had a bit more description above the sign off and perhaps a shorter title.
I'd have left the 'how' element of the patch to this extra description and not put it in the title.

Also, minor typo waring-> warning.

I'll fix that up.

Applied to the togreg branch of iio.git and pushed out as testing from the pharma cleanroom where I have surprisingly good internet access!

Jonathan
> ---
>  drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> index 38dca69..9658f20 100644
> --- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> +++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> @@ -133,7 +133,7 @@ static ssize_t iio_bfin_tmr_frequency_show(struct device *dev,
>  	return sprintf(buf, "%lu\n", val);
>  }
>  
> -static DEVICE_ATTR(frequency, S_IRUGO | S_IWUSR, iio_bfin_tmr_frequency_show,
> +static DEVICE_ATTR(frequency, 0644, iio_bfin_tmr_frequency_show,
>  		   iio_bfin_tmr_frequency_store);
>  
>  static struct attribute *iio_bfin_tmr_trigger_attrs[] = {
> 

Re: [PATCH] iio:trigger: Fix coding style in iio-trig-bfin-timer.c by removing a waring flagged by checkpatch.pl

[Jonathan Cameron]

On 07/01/17 11:59, Jonathan Cameron wrote:
> On 07/01/17 05:51, rishabh hardas wrote:
>> Signed-off-by: rishabh hardas <rishabheudyptula@gmail.com>
> Ideally you'd have had a bit more description above the sign off and perhaps a shorter title.
> I'd have left the 'how' element of the patch to this extra description and not put it in the title.
> 
> Also, minor typo waring-> warning.
> 
> I'll fix that up.
> 
> Applied to the togreg branch of iio.git and pushed out as testing
> from the pharma cleanroomwhere I have surprisingly good internet
> access!

Or not pushed out as something is blocking my connection.  Might be a day or two
before I get on a sensible connection!

Jonathan
> Jonathan
>> ---
>>  drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
>> index 38dca69..9658f20 100644
>> --- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
>> +++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
>> @@ -133,7 +133,7 @@ static ssize_t iio_bfin_tmr_frequency_show(struct device *dev,
>>  	return sprintf(buf, "%lu\n", val);
>>  }
>>  
>> -static DEVICE_ATTR(frequency, S_IRUGO | S_IWUSR, iio_bfin_tmr_frequency_show,
>> +static DEVICE_ATTR(frequency, 0644, iio_bfin_tmr_frequency_show,
>>  		   iio_bfin_tmr_frequency_store);
>>  
>>  static struct attribute *iio_bfin_tmr_trigger_attrs[] = {
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>