From: Marten Lindahl <martenli@axis.com>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Mårten Lindahl" <marten.lindahl@axis.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>, <linux-iio@vger.kernel.org>,
<kernel@axis.com>
Subject: Re: [PATCH v4 1/3] iio: light: vcnl4000: Prepare for more generic setup
Date: Tue, 17 Jan 2023 18:07:30 +0100 [thread overview]
Message-ID: <1a4c8717-8b79-c102-6c2e-01233e0e8eb4@axis.com> (raw)
In-Reply-To: <Y8bEGIj1JAjyaEg6@smile.fi.intel.com>
On 1/17/23 16:51, Andy Shevchenko wrote:
> On Tue, Jan 17, 2023 at 04:24:33PM +0100, Mårten Lindahl wrote:
>> In order to allow the chip_spec array reference the function pointers
>> for interrupts, the code for these functions need to be moved above the
>> chip_spec array.
>>
>> This is a prestep to support a more generic setup of interrupts.
> ...
>
>> + u16 buffer[8] __aligned(8) = {0}; /* 1x16-bit + naturally aligned ts */
> I understand that this just a code move without a single change, but
> I have to ask. Don't we use the specific struct layout for this?
>
> Also, 0 is redundant.
>
> P.S. Maybe considered as a followup change(s).
>
Hi Andy! I see your point. But yes, as it's not directly part of my
change I'd prefer to handle it separately from this patch series.
Kind regards
Mårten
next prev parent reply other threads:[~2023-01-17 17:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 15:24 [PATCH v4 0/3] iio: light: vcnl4000: Add vcnl4040 interrupt support Mårten Lindahl
2023-01-17 15:24 ` [PATCH v4 1/3] iio: light: vcnl4000: Prepare for more generic setup Mårten Lindahl
2023-01-17 15:51 ` Andy Shevchenko
2023-01-17 17:07 ` Marten Lindahl [this message]
2023-01-17 15:24 ` [PATCH v4 2/3] iio: light: vcnl4000: Make irq handling more generic Mårten Lindahl
2023-01-17 15:53 ` Andy Shevchenko
2023-01-17 17:09 ` Marten Lindahl
2023-01-17 15:24 ` [PATCH v4 3/3] iio: light: vcnl4000: Add interrupt support for vcnl4040 Mårten Lindahl
2023-01-17 15:58 ` Andy Shevchenko
2023-01-17 15:59 ` Andy Shevchenko
2023-01-17 17:14 ` Marten Lindahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a4c8717-8b79-c102-6c2e-01233e0e8eb4@axis.com \
--to=martenli@axis.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=kernel@axis.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=marten.lindahl@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox