From: Greg KH <greg@kroah.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: michael.hennerich@analog.com, jic23@cam.ac.uk,
linux-iio@vger.kernel.org, drivers@analog.com,
device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH] IIO: TRIGGER: New sysfs based trigger
Date: Wed, 2 Feb 2011 12:26:41 -0800 [thread overview]
Message-ID: <20110202202641.GA28479@kroah.com> (raw)
In-Reply-To: <20110202195001.GH9810@sirena.org.uk>
On Wed, Feb 02, 2011 at 07:50:01PM +0000, Mark Brown wrote:
> On Wed, Feb 02, 2011 at 11:43:18AM -0800, Greg KH wrote:
> > On Wed, Feb 02, 2011 at 08:21:08PM +0100, michael.hennerich@analog.com wrote:
>
> > > +static struct platform_driver iio_sysfs_trigger_driver = {
> > > + .driver = {
> > > + .name = "iio_sysfs_trigger",
> > > + .owner = THIS_MODULE,
> > > + },
> > > + .probe = iio_sysfs_trigger_probe,
> > > + .remove = __devexit_p(iio_sysfs_trigger_remove),
> > > +};
>
> > Why is this a platform device? It doesn't seem to be platform specific
> > at all, does it?
>
> Platform devices are used throughout the embedded kernel for virtual
> devices
Yes, but that doesn't mean they should be.
> - the MFD subsystem is one of the most obvious examples here.
Don't make a device a "platform" device unless it really is one. This
one isn't one, it's a "virtual" device, right?
thanks,
greg k-h
next prev parent reply other threads:[~2011-02-02 20:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 19:21 [PATCH] IIO: TRIGGER: New sysfs based trigger michael.hennerich
2011-02-02 19:42 ` Greg KH
2011-02-02 19:55 ` Hennerich, Michael
2011-02-02 20:27 ` Greg KH
2011-02-02 20:36 ` Hennerich, Michael
2011-02-02 20:47 ` Mark Brown
2011-02-02 20:58 ` Greg KH
2011-02-03 9:58 ` Hennerich, Michael
2011-02-03 17:13 ` Greg KH
2011-02-04 8:38 ` Hennerich, Michael
2011-02-04 10:51 ` Jonathan Cameron
2011-02-04 14:55 ` Greg KH
2011-02-04 15:27 ` Jonathan Cameron
2011-02-04 15:34 ` Hennerich, Michael
2011-02-04 15:44 ` Jonathan Cameron
2011-02-02 19:43 ` Greg KH
2011-02-02 19:50 ` Mark Brown
2011-02-02 20:26 ` Greg KH [this message]
2011-02-02 20:31 ` Mark Brown
2011-02-02 20:48 ` Greg KH
2011-02-02 20:13 ` Hennerich, Michael
2011-02-02 20:29 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2011-02-07 10:05 michael.hennerich
2011-02-03 10:10 michael.hennerich
2011-02-02 13:30 michael.hennerich
2011-02-02 18:22 ` Jonathan Cameron
2011-02-02 19:21 ` Hennerich, Michael
2011-02-03 10:13 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110202202641.GA28479@kroah.com \
--to=greg@kroah.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox