From: Arnd Bergmann <arnd@arndb.de>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: linux-iio@vger.kernel.org, Michael.Hennerich@analog.com
Subject: Re: [RFC PATCH] IIO: break out const elements of iio_dev configuration
Date: Wed, 27 Apr 2011 15:58:37 +0200 [thread overview]
Message-ID: <201104271558.37971.arnd@arndb.de> (raw)
In-Reply-To: <1303898975-26215-1-git-send-email-jic23@cam.ac.uk>
On Wednesday 27 April 2011, Jonathan Cameron wrote:
> In conclusion max1363 gets bigger in all ways if we break this
> stuff out. That is just down to the large number of devices supported.
> lis3l02dq which supports only one part gets smaller.
>
> So not a clear descision either way as far as I am concerned, but
> putting the channel_spec into this structure is pretty costly for
> typical multipart drivers.
>
> So the upshot of this RFC to my mind is: Is the clarity gained
> a good idea?
>
> What do people think?
I suggested this initially, so it shouldn't surprise that I like
the patch.
For the increase in size, that seems to be purely because of the
change in one data structure from bool to pointer, right?
If you reorder the members of max1363_chip_info to remove the
padding, I think you can make up for that.
Arnd
next prev parent reply other threads:[~2011-04-27 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 10:09 [RFC PATCH] IIO: break out const elements of iio_dev configuration Jonathan Cameron
2011-04-27 13:58 ` Arnd Bergmann [this message]
2011-04-27 15:05 ` Jonathan Cameron
2011-04-29 12:42 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104271558.37971.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox