Linux IIO development
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: linux-iio@vger.kernel.org, Michael.Hennerich@analog.com
Subject: Re: [PATCH 00/99] IIO: moving forward patch set.
Date: Wed, 4 May 2011 15:33:21 +0200	[thread overview]
Message-ID: <201105041533.21498.arnd@arndb.de> (raw)
In-Reply-To: <1304510351-10922-1-git-send-email-jic23@cam.ac.uk>

On Wednesday 04 May 2011, Jonathan Cameron wrote:
> First to Arnd: Obviously I'm not expecting you to review this
> 'little' set. I just wanted to keep you in the loop on what happened
> with your suggestions.
> 

Thanks for the update, this looks like excellent progress!

I've briefly looked over most of the patches and they all look good
to me, I especially like the total diffstat of 
 112 files changed, 7402 insertions(+), 12638 deletions(-)

One of the main problems we discussed earlier is the chardev interface
with its event handling, and I think you got it exactly right now, but
I'm not completely sure if I understand correctly what you do there,
so maybe you can explain how it works with the new buffer device.

Ideally, that could be in man-page style so it can go into section 4 of
the man pages, /usr/share/man/man4/iio.4.

	Arnd

  parent reply	other threads:[~2011-05-04 13:33 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-04 11:57 [PATCH 00/99] IIO: moving forward patch set Jonathan Cameron
2011-05-04 11:57 ` [PATCH 01/99] staging:iio: allow channels to be set up using a table of iio_channel_spec structures Jonathan Cameron
2011-05-04 11:57 ` [PATCH 02/99] staging:iio:lis3l02dq - move to new channel_spec approach Jonathan Cameron
2011-05-04 11:57 ` [PATCH 03/99] staging:iio:max1363 - move to channel_spec registration Jonathan Cameron
2011-05-04 11:57 ` [PATCH 04/99] staging:iio: remove ability to escalate events Jonathan Cameron
2011-05-04 11:57 ` [PATCH 05/99] staging:iio: Add polling of events on the ring access chrdev Jonathan Cameron
2011-05-04 11:57 ` [PATCH 06/99] staging:iio: remove legacy event chrdev for the buffers Jonathan Cameron
2011-05-04 11:57 ` [PATCH 07/99] staging:iio: Buffer device flattening Jonathan Cameron
2011-05-04 11:57 ` [PATCH 08/99] staging:iio:lis3l02dq: General cleanup Jonathan Cameron
2011-05-04 11:57 ` [PATCH 09/99] staging:iio: Push interrupt setup down into the drivers for event lines Jonathan Cameron
2011-05-04 11:57 ` [PATCH 10/99] staging:iio: lis3l02dq - separate entirely interrupt handling for thesholds from that for the datardy signal Jonathan Cameron
2011-05-04 11:57 ` [PATCH 11/99] staging:iio:sca3000 extract old event handling and move to poll for events from buffer Jonathan Cameron
2011-05-04 11:57 ` [PATCH 12/99] staging:iio:buffering remove unused parameter dead_offset from read_last_n in all buffer implementations Jonathan Cameron
2011-05-04 11:57 ` [PATCH 13/99] staging:iio:light:tsl2563 remove old style event registration Jonathan Cameron
2011-05-04 11:57 ` [PATCH 14/99] staging:iio:dac:ad5504 move from old to new event handling Jonathan Cameron
2011-05-04 11:57 ` [PATCH 15/99] staging:iio:adt7316 get rid of legacy event handling code Jonathan Cameron
2011-05-04 11:57 ` [PATCH 16/99] staging:iio:adc:ad7745 move from old to current event handling Jonathan Cameron
2011-05-04 11:57 ` [PATCH 17/99] staging:iio:adc:ad7816 " Jonathan Cameron
2011-05-04 11:57 ` [PATCH 18/99] staging:iio:adc:ad7150 move from deprecated event handling plus remove irq as gpio requirement Jonathan Cameron
2011-05-04 11:57 ` [PATCH 19/99] staging:iio:adc:ad7152 remove unregister of interrupt line Jonathan Cameron
2011-05-04 11:57 ` [PATCH 20/99] staging:iio:adc:adt75 old to new event handling conversion Jonathan Cameron
2011-05-04 11:57 ` [PATCH 21/99] staging:iio:ad7291 move from old event system to current Jonathan Cameron
2011-05-04 11:57 ` [PATCH 22/99] staging:iio:adc:adt7410 move to current event handling Jonathan Cameron
2011-05-04 11:57 ` [PATCH 23/99] staging:iio:adt7310 " Jonathan Cameron
2011-05-04 11:57 ` [PATCH 24/99] staging:iio:adc:ad7314 remove unmatched unregister of event line Jonathan Cameron
2011-05-04 11:57 ` [PATCH 25/99] staging:iio:ad799x move to new event handling Jonathan Cameron
2011-05-04 11:57 ` [PATCH 26/99] staging:iio: Remove legacy " Jonathan Cameron
2011-05-04 11:57 ` [PATCH 27/99] staging:iio:lis3l02dq make threshold interrupt threaded Jonathan Cameron
2011-05-04 11:58 ` [PATCH 28/99] staging:iio: Add infrastructure for irq_chip based triggers Jonathan Cameron
2011-05-04 11:58 ` [PATCH 29/99] staging:iio:Documentation generic_buffer.c update to new abi for buffers + misc fixes Jonathan Cameron
2011-05-04 11:58 ` [PATCH 30/99] staging:iio:ring_sw add function needed for threaded irq Jonathan Cameron
2011-05-04 11:58 ` [PATCH 31/99] staging:iio: add generic data ready poll function Jonathan Cameron
2011-05-04 11:58 ` [PATCH 32/99] staging:iio:lis3l02dq move to threaded trigger handling Jonathan Cameron
2011-05-04 11:58 ` [PATCH 33/99] staging:iio:max1363 move to irqchip based threaded irq triggering Jonathan Cameron
2011-05-04 11:58 ` [PATCH 34/99] staging:iio:ad7476 use channel_spec Jonathan Cameron
2011-05-04 11:58 ` [PATCH 35/99] staging:iio:ad7476 move to irqchip based triggering Jonathan Cameron
2011-05-04 11:58 ` [PATCH 36/99] staging:iio:meter:ade7758 move to irqchip based trigger handling Jonathan Cameron
2011-05-04 11:58 ` [PATCH 37/99] staging:iio:adis16400 move to irq based triggers and channel spec channel registration Jonathan Cameron
2011-05-04 11:58 ` [PATCH 38/99] staging:iio:imu:adis16350 etc support into adis16400 driver Jonathan Cameron
2011-05-04 11:58 ` [PATCH 39/99] staging:iio:imu remove old adis16350. Support now in " Jonathan Cameron
2011-05-04 11:58 ` [PATCH 40/99] staging:iio:imu:adis16400 add support for adis16300 Jonathan Cameron
2011-05-04 11:58 ` [PATCH 41/99] staging:iio:imu remove adis16300 driver Jonathan Cameron
2011-05-04 11:58 ` [PATCH 42/99] staging:iio:accel:adis16201 move to irqchip based trigger handling Jonathan Cameron
2011-05-04 11:58 ` [PATCH 43/99] staging:iio:accel:adis16203 " Jonathan Cameron
2011-05-04 11:58 ` [PATCH 44/99] staging:iio:accel:adis16204 " Jonathan Cameron
2011-05-04 11:58 ` [PATCH 45/99] staging:iio:accel:adis16209 " Jonathan Cameron
2011-05-04 11:58 ` [PATCH 46/99] staging:iio:accel:adis16240 " Jonathan Cameron
2011-05-04 11:58 ` [PATCH 47/99] staging:iio:adc:ad7298 " Jonathan Cameron
2011-05-04 11:58 ` [PATCH 48/99] staging:iio:ad7606 conversion to irq_chip based polling Jonathan Cameron
2011-05-04 11:58 ` [PATCH 49/99] staging:iio:adc:ad7887 move to irqchip based trigger handling Jonathan Cameron
2011-05-04 11:58 ` [PATCH 50/99] staging:iio:adc:ad799x " Jonathan Cameron
2011-05-04 11:58 ` [PATCH 51/99] staging:iio:gyro:adis16260 " Jonathan Cameron
2011-05-04 11:58 ` [PATCH 52/99] staging:iio:trigger remove legacy pollfunc elements Jonathan Cameron
2011-05-04 11:58 ` [PATCH 53/99] staging:iio: Add core attribute handling for name of device Jonathan Cameron
2011-05-04 11:58 ` [PATCH 54/99] staging:iio: use the new central name attribute creation code Jonathan Cameron
2011-05-04 11:58 ` [PATCH 55/99] staging:iio:light:tsl2563: chan_spec based channel setup Jonathan Cameron
2011-05-04 11:58 ` [PATCH 56/99] staging:iio:accel:adis16201 move to chan_spec based setup Jonathan Cameron
2011-05-04 11:58 ` [PATCH 57/99] staging:iio:accel:adis16203 " Jonathan Cameron
2011-05-04 11:58 ` [PATCH 58/99] staging:iio:accel:adis16204 " Jonathan Cameron
2011-05-04 11:58 ` [PATCH 59/99] staging:iio:accel:adis16209 " Jonathan Cameron
2011-05-04 11:58 ` [PATCH 60/99] IIO-onwards: ADC: AD7887: Convert to new channel registration method Jonathan Cameron
2011-05-04 11:58 ` [PATCH 61/99] IIO-onwards: ADC: AD7887: Use private data space from iio_allocate_device Jonathan Cameron
2011-05-04 11:58 ` [PATCH 62/99] IIO-onwards: ADC: AD799x: Convert to new channel registration method Jonathan Cameron
2011-05-04 11:58 ` [PATCH 63/99] IIO-onwards: ADC: AD799x: Use private data space from iio_allocate_device Jonathan Cameron
2011-05-04 11:58 ` [PATCH 64/99] staging:iio:adc/ad799x removed unused headers Jonathan Cameron
2011-05-04 11:58 ` [PATCH 65/99] IIO-onwards: ADC: AD7298: Convert to new channel registration method Jonathan Cameron
2011-05-04 11:58 ` [PATCH 66/99] staging:iio:accel: lis3l02dq add writing for calibscale and calibbias Jonathan Cameron
2011-05-04 11:58 ` [PATCH 67/99] staging:iio: Add chan info support for 'peak_raw' attributes Jonathan Cameron
2011-05-04 11:58 ` [PATCH 68/99] staging:iio:accel:adis16240 move to chan_spec based setup Jonathan Cameron
2011-05-04 11:58 ` [PATCH 69/99] staging:iio:gyro:adis16260 " Jonathan Cameron
2011-05-04 11:58 ` [PATCH 70/99] staging:iio:adc:ad7606 Convert to new channel registration method Update Add missing call to iio_trigger_notify_done() Set pollfunc top and bottom half handler Jonathan Cameron
2011-05-04 11:58 ` [PATCH 71/99] staging:iio:adc:ad7606: Use private data space from iio_allocate_device Jonathan Cameron
2011-05-04 11:58 ` [PATCH 72/99] staging:iio: rip out scan_el attributes. Now handled as iio_dev_attrs like everything else Jonathan Cameron
2011-05-04 11:58 ` [PATCH 73/99] staging:iio:max1363 trivial removal of unused trig pointer Jonathan Cameron
2011-05-04 11:58 ` [PATCH 74/99] staging:iio:max1363 add new 2 channels parts form maxim, 11644-7 Jonathan Cameron
2011-05-04 11:58 ` [PATCH 75/99] staging:iio:trigger sysfs userspace trigger rework Jonathan Cameron
2011-05-04 11:58 ` [PATCH 76/99] staging:iio:core clean out unused elements Jonathan Cameron
2011-05-04 11:58 ` [PATCH 77/99] staging:iio:adc:ad7150 fix event codes Jonathan Cameron
2011-05-04 11:58 ` [PATCH 78/99] staging:iio:adc:ad7816 and adt75 change to meaningful event code Jonathan Cameron
2011-05-04 11:58 ` [PATCH 79/99] staging:iio:adc:ad7291 remove abuse of buffer events and replace with something almost sane Jonathan Cameron
2011-05-04 11:58 ` [PATCH 80/99] staging:iio:adc:adt7310 replace abuse of buffer events Jonathan Cameron
2011-05-04 11:58 ` [PATCH 81/99] staging:iio:adc:adt7410 " Jonathan Cameron
2011-05-04 11:58 ` [PATCH 82/99] staging:iio:addac:adt7316 " Jonathan Cameron
2011-05-04 11:58 ` [PATCH 83/99] staging:iio:buffer - remove unused event code for " Jonathan Cameron
2011-05-04 11:58 ` [PATCH 84/99] staging:iio:lis3l02dq remerge the two interrupt handlers Jonathan Cameron
2011-05-04 11:58 ` [PATCH 85/99] staging:iio: iio_event_interfaces - clean out unused elements Jonathan Cameron
2011-05-04 11:58 ` [PATCH 86/99] staging:iio:trigger handle name attr in core, remove old alloc and register any control_attrs via struct device Jonathan Cameron
2011-05-04 11:58 ` [PATCH 87/99] drivers:staging:iio:adis16400 avoid allocating rx, tx, and state separately from iio_dev Jonathan Cameron
2011-05-04 11:59 ` [PATCH 88/99] staging:iio: rationalization of different buffer implementation hooks Jonathan Cameron
2011-05-04 11:59 ` [PATCH 89/99] staging:iio:adc:AD7298: Use private data space from iio_allocate_device Jonathan Cameron
2011-05-04 11:59 ` [PATCH 90/99] staging:iio: Rip out helper for software rings Jonathan Cameron
2011-05-04 11:59 ` [PATCH 91/99] staging:iio:adc: AD7606: Consitently use indio_dev Jonathan Cameron
2011-05-04 11:59 ` [PATCH 92/99] staging:iio:adc: AD7606: Drop dev_data in favour of iio_priv() Jonathan Cameron
2011-05-04 11:59 ` [PATCH 93/99] staging:iio:adc:AD7780: Convert to new channel registration method Jonathan Cameron
2011-05-04 11:59 ` [PATCH 94/99] staging:iio:adc: AD7780: Use private data space from iio_allocate_device + trivial fixes Jonathan Cameron
2011-05-04 11:59 ` [PATCH 95/99] staging:iio:ad7780 trivial unused header cleanup Jonathan Cameron
2011-05-04 11:59 ` [PATCH 96/99] staging:iio: poll func allocation clean up Jonathan Cameron
2011-05-04 11:59 ` [PATCH 97/99] staging:iio:core cleanup: squash tiny wrappers and use dev_set_name to handle creation of event interface name Jonathan Cameron
2011-05-04 11:59 ` [PATCH 98/99] staging:iio: ring core cleanups + check if read_last available in lis3l02dq Jonathan Cameron
2011-05-04 11:59 ` [PATCH 99/99] staging:iio:accel:lis3l02dq make write_reg_8 take value not a pointer to value Jonathan Cameron
2011-05-04 13:33 ` Arnd Bergmann [this message]
2011-05-04 15:01   ` [PATCH 00/99] IIO: moving forward patch set Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201105041533.21498.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=Michael.Hennerich@analog.com \
    --cc=jic23@cam.ac.uk \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox