From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <greg@kroah.com>
Date: Wed, 24 Aug 2011 08:10:38 -0700
From: Greg KH <greg@kroah.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: linux-iio@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] Sysfs group create for empty groups.
Message-ID: <20110824151038.GB25080@kroah.com>
References: <1313576222-27743-1-git-send-email-jic23@cam.ac.uk>
 <4E4BEBFD.3040004@cam.ac.uk>
 <20110823003352.GA5982@kroah.com>
 <4E538896.3050006@cam.ac.uk>
 <4E53FEA9.3010408@cam.ac.uk>
 <20110823220311.GA15689@kroah.com>
 <4E54EBA5.9040103@cam.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <4E54EBA5.9040103@cam.ac.uk>
List-ID: <linux-iio@vger.kernel.org>

On Wed, Aug 24, 2011 at 01:16:37PM +0100, Jonathan Cameron wrote:
> I've dropped lkml on this discussion seeing as it will now be all linux-iio
> stuff.
> 
> Anyhow, I've put together a patch set that does this on top of iio-blue.git.
> 
> Unfortunately it requires changes in a lot of drivers.
> 
> Basically you have to do iio_device_register last - after all ring and trigger
> registrations (previously it had to be first).
> 
> Has the nice side effect of removing the need for that nasty regdone trick
> that quite a lot of drivers use.
> 
> Sorry all but this will break almost all drivers currently out of tree.

That provides a good goal for people to get their driver into the tree
:)

> I wasn't too nasty to implement, though it does mean embedding attribute_group
> structures in struct iio_dev, struct iio_ring_buffer and struct iio_event_interface
> and dynamically allocating the struct attribute pointer arrays + remembering to
> free them.  That's all in the core though so as long as I haven't messed up shouldn't
> effect anyone.
> 
> + now we should get all the right notifications for file creation.
> 
> Will post patches once I've done all the driver reorderings as stated above.

Sounds good, thanks for letting me know.

greg k-h