From: "Maxin B. John" <maxin.john@gmail.com>
To: Amit Kucheria <amit.kucheria@verdurent.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
Greg Kroah-Hartman <gregkh@suse.de>,
Bryan Freed <bfreed@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] staging: iio: light: Fix compiler warning in tsl2563.c
Date: Fri, 2 Sep 2011 00:24:13 +0300 [thread overview]
Message-ID: <20110901212413.GA3371@maxin> (raw)
CC [M] drivers/staging/iio/light/tsl2563.o
drivers/staging/iio/light/tsl2563.c: In function 'tsl2563_probe':
drivers/staging/iio/light/tsl2563.c:736: warning: 'id' may be used
uninitialized in this function
Also fixes the tsl2563_read_id().
Signed-off-by: Maxin B. John <maxin.john@gmail.com>
---
diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c
index f25243b..f8f787d 100644
--- a/drivers/staging/iio/light/tsl2563.c
+++ b/drivers/staging/iio/light/tsl2563.c
@@ -225,9 +225,9 @@ static int tsl2563_read_id(struct tsl2563_chip *chip, u8 *id)
ret = i2c_smbus_read_byte_data(client, TSL2563_CMD | TSL2563_REG_ID);
if (ret < 0)
- return ret;
+ return -EIO;
- return 0;
+ return ret;
}
/*
@@ -697,7 +697,7 @@ static int __devinit tsl2563_probe(struct i2c_client *client,
struct tsl2563_platform_data *pdata = client->dev.platform_data;
int err = 0;
int ret;
- u8 id;
+ u8 id = 0;
indio_dev = iio_allocate_device(sizeof(*chip));
if (!indio_dev)
@@ -709,15 +709,17 @@ static int __devinit tsl2563_probe(struct i2c_client *client,
chip->client = client;
err = tsl2563_detect(chip);
- if (err) {
+ if (err < 0) {
dev_err(&client->dev, "device not found, error %d\n", -err);
goto fail1;
}
err = tsl2563_read_id(chip, &id);
- if (err)
+ if (err < 0) {
+ dev_err(&client->dev, "id reading failed, error %d\n", -err);
goto fail1;
-
+ }
+ id = err;
mutex_init(&chip->lock);
/* Default values used until userspace says otherwise */
next reply other threads:[~2011-09-01 21:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 21:24 Maxin B. John [this message]
2011-09-01 21:55 ` [PATCH] staging: iio: light: Fix compiler warning in tsl2563.c Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2011-09-02 9:41 Maxin B. John
2011-09-02 10:55 ` Jonathan Cameron
2011-10-22 5:15 ` Maxin B John
2011-10-24 8:51 ` Jonathan Cameron
[not found] ` <20111024090143.GB3526@mwanda>
2011-10-24 9:14 ` Jonathan Cameron
[not found] ` <CAMhs6Yz6B_imMAthjjpymXj1garYzjFdzXfEArUwztmpgL4_hg@mail.gmail.com>
2011-10-24 9:15 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110901212413.GA3371@maxin \
--to=maxin.john@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=arnd@arndb.de \
--cc=bfreed@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).