From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 2 Sep 2011 12:41:07 +0300 From: "Maxin B. John" To: Dan Carpenter Cc: Jonathan Cameron , Bryan Freed , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , linux-iio@vger.kernel.org, Arnd Bergmann , devel@driverdev.osuosl.org, Amit Kucheria Subject: Re: [PATCH] staging: iio: light: Fix compiler warning in tsl2563.c Message-ID: <20110902094107.GA2846@maxin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-ID: > Don't overwrite the error code. For example, the lower layers can > return -EAGAIN and that's more useful than just returning -EIO every > time. Ahh.. Thanks a lot for explaining this. > Your fix works, but it's not very clean. Just add a "*id = ret;" > line before the "return 0;" and that's it. (It doesn't make sense > to pass a pointer to "id" and not use it). Dan, yes, I agree with you. This fix is much much better than what I had in my mind. > Yikes - I wonder why my various compilers don't throw that up. I guess, in "iio-blue.git" tree, the 'id = 0' suppresses this warning. Signed-off-by: Maxin B. John --- diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c index f25243b..55012ff 100644 --- a/drivers/staging/iio/light/tsl2563.c +++ b/drivers/staging/iio/light/tsl2563.c @@ -226,7 +226,7 @@ static int tsl2563_read_id(struct tsl2563_chip *chip, u8 *id) ret = i2c_smbus_read_byte_data(client, TSL2563_CMD | TSL2563_REG_ID); if (ret < 0) return ret; - + *id = ret; return 0; }