linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Grant Grundler <grundler@google.com>,
	Jonathan Cameron <jic23@cam.ac.uk>,
	devel@linuxdriverproject.org, linux-iio@vger.kernel.org,
	bfreed@chromium.org, grundler@chromium.org
Subject: Re: [PATCH] STAGING:iio:light: V2 fix out of bounds reg_cache[] access
Date: Tue, 6 Sep 2011 16:05:33 -0700	[thread overview]
Message-ID: <20110906230533.GA5882@kroah.com> (raw)
In-Reply-To: <20110830235546.3135B208185@grundler.mtv.corp.google.com>

On Tue, Aug 30, 2011 at 04:55:46PM -0700, Grant Grundler wrote:
> V2 Fix out-of-bounds reference to reg_cache[]
> 
> Simple fix is to just not cache REG_TEST (offset 8).
> Cache doesn't help REG_TEST anyway since we write all 8 bits exactly once
> (at resume/init time).
> 
> Also fix an "off-by-one" allocation of reg_cache[] array size that
> was in the original code before I touched it.
> 
> Reported-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Grant Grundler <grundler@chromium.org>
> Acked-by: Jonathan Cameron <jic23@cam.ac.uk>

Jonathan, this no longer applies after your other patches, so could you
queue this up in your tree and resend it in a format that applies?

thanks,

greg k-h

  parent reply	other threads:[~2011-09-06 23:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-30 23:55 [PATCH] STAGING:iio:light: V2 fix out of bounds reg_cache[] access Grant Grundler
2011-08-31 13:41 ` Jonathan Cameron
2011-09-06 23:05 ` Greg KH [this message]
2011-09-09  8:53   ` [PATCH] [PATCH] staging:iio:light: V3 " Jonathan Cameron
2011-09-09  8:54     ` Jonathan Cameron
2011-09-09 15:20       ` Grant Grundler
2011-09-09 15:41         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110906230533.GA5882@kroah.com \
    --to=greg@kroah.com \
    --cc=bfreed@chromium.org \
    --cc=devel@linuxdriverproject.org \
    --cc=grundler@chromium.org \
    --cc=grundler@google.com \
    --cc=jic23@cam.ac.uk \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).