linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	Jonathan Cameron <jic23@kernel.org>,
	devel@driverdev.osuosl.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 3/3] staging:iio: Fix scan mask update
Date: Thu, 8 Dec 2011 12:18:41 -0800	[thread overview]
Message-ID: <20111208201841.GA338@kroah.com> (raw)
In-Reply-To: <1323365753-7645-3-git-send-email-lars@metafoo.de>

On Thu, Dec 08, 2011 at 06:35:53PM +0100, Lars-Peter Clausen wrote:
> When updating the scan mask we have to check the actual scan mask for=
 if the
> channel is already enabled, not the matching scan mask from the avail=
able
> scan masks. The bit will already be set there and as a result the act=
ual
> scan mask will not get updated and the channel stays disabled.
>=20
> Also fix the return value of iio_scan_el_store which would return 1 i=
nstead of
> the number of bytes written if the channel was already active in the =
scan mask.

You just added a complier warning with this patch:
  CC [M]  drivers/staging/iio/industrialio-buffer.o
drivers/staging/iio/industrialio-buffer.c: In function =E2=80=98iio_sca=
n_mask_query=E2=80=99:
drivers/staging/iio/industrialio-buffer.c:621:8: warning: unused variab=
le =E2=80=98mask=E2=80=99 [-Wunused-variable]

So I didn't apply it.

Care to try again and be more careful in the future?

thanks,

greg k-h

  reply	other threads:[~2011-12-08 20:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-08 17:35 [PATCH 1/3] staging:iio: Fix sw_ring memory corruption Lars-Peter Clausen
2011-12-08 17:35 ` [PATCH 2/3] staging:iio:kfifo_buf: Fix potential buffer overflow in iio_read_first_n_kfifo Lars-Peter Clausen
     [not found]   ` <20111208201722.GA31926@kroah.com>
2011-12-09  9:58     ` Lars-Peter Clausen
2011-12-09 15:11       ` Greg KH
2011-12-08 17:35 ` [PATCH 3/3] staging:iio: Fix scan mask update Lars-Peter Clausen
2011-12-08 20:18   ` Greg KH [this message]
2011-12-09  9:49     ` Lars-Peter Clausen
2011-12-09 15:11       ` Greg KH
2011-12-18 18:02         ` Jonathan Cameron
2011-12-18 19:44           ` Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111208201841.GA338@kroah.com \
    --to=greg@kroah.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).