From: Dan Carpenter <dan.carpenter@oracle.com>
To: Johannes Tenschert <Johannes.Tenschert@informatik.stud.uni-erlangen.de>
Cc: devel@linuxdriverproject.org, linux-iio@vger.kernel.org,
gregkh@suse.de, jic23@cam.ac.uk, jbrenner@taosinc.com
Subject: Re: staging: iio: light: obsolete use of strict_strtoul v2
Date: Tue, 13 Dec 2011 09:33:50 +0300 [thread overview]
Message-ID: <20111213063350.GF3503@mwanda> (raw)
In-Reply-To: <1323733102-7868-1-git-send-email-Johannes.Tenschert@informatik.stud.uni-erlangen.de>
[-- Attachment #1: Type: text/plain, Size: 527 bytes --]
On Tue, Dec 13, 2011 at 12:38:20AM +0100, Johannes Tenschert wrote:
> Hi,
>
> I changed the patch to use the right kstrto* as Dan Carpenter suggested, but
> I'm not familiar enough with the code to fix the divide by zero bug in a good
> way.
>
> I also didn't change taos_settings because I don't know it well enough and don't
> want to introduce new bugs. So kstrtoint was used provisional to set it.
Yah, yah. Neither of us know the code, so hopefully the iio people
can comment.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-12-13 6:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 23:38 staging: iio: light: obsolete use of strict_strtoul v2 Johannes Tenschert
2011-12-12 23:38 ` [PATCH v2 1/2] staging: iio: light: isl29018.c: obsolete use of strict_strtoul Johannes Tenschert
2011-12-12 23:38 ` [PATCH v2 2/2] staging: iio: light: tsl2583.c: " Johannes Tenschert
2011-12-13 6:33 ` Dan Carpenter [this message]
2011-12-14 20:11 ` staging: iio: light: obsolete use of strict_strtoul v2 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213063350.GF3503@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Johannes.Tenschert@informatik.stud.uni-erlangen.de \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=jbrenner@taosinc.com \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).