From: Greg KH <gregkh@suse.de>
To: "J.I. Cameron" <jic23@cam.ac.uk>
Cc: Greg KH <greg@kroah.com>, Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>,
devel@driverdev.osuosl.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH] staging:iio: Setup buffer access functions when allocating the buffer
Date: Tue, 13 Dec 2011 16:00:43 -0800 [thread overview]
Message-ID: <20111214000043.GA23927@suse.de> (raw)
In-Reply-To: <Prayer.1.3.4.1112130848080.6245@hermes-2.csi.cam.ac.uk>
On Tue, Dec 13, 2011 at 08:48:08AM +0000, J.I. Cameron wrote:
> >>>Make a decision, don't force someone else to make it for you...
> >>Defaults are sensible. Preventing other peoples use cases are not.
> >
> >Ok, but you do agree that this patch is broken as-is, right?
> Not sure I do. I admit it isn't a patch I really cared about either way,
> but it is just providing a trivial bit of boiler plate removal.
> The buffer allocation and access functions are always pared and all I see
> here is moving the access funcs bit inside the allocation call?
>
> Perhaps I have missunderstood what you don't like?
I don't like anything that forces the builder of the kernel to choose
the buffer type, that should be done by the driver, or it should be
dynamic and changable, and you need to provide documentation as to why
you would want to change the buffer type.
greg k-h
next prev parent reply other threads:[~2011-12-14 0:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 10:09 [PATCH] staging:iio: Setup buffer access functions when allocating the buffer Lars-Peter Clausen
2011-12-13 0:46 ` Greg KH
2011-12-13 7:23 ` Jonathan Cameron
2011-12-13 7:38 ` Greg KH
2011-12-13 8:48 ` J.I. Cameron
2011-12-14 0:00 ` Greg KH [this message]
2011-12-14 7:21 ` Jonathan Cameron
2011-12-13 9:08 ` Lars-Peter Clausen
2011-12-13 0:52 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2011-12-28 11:32 Lars-Peter Clausen
2011-12-31 20:01 ` Jonathan Cameron
2012-01-03 10:02 Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214000043.GA23927@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=jic23@cam.ac.uk \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).