From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Greg KH <greg@kroah.com>,
devel@driverdev.osuosl.org, linux-iio@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] staging:iio: Add wrapper functions around buffer access ops
Date: Wed, 14 Dec 2011 17:31:44 +0300 [thread overview]
Message-ID: <20111214143144.GL3503@mwanda> (raw)
In-Reply-To: <4EE87755.3000000@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
On Wed, Dec 14, 2011 at 11:15:49AM +0100, Lars-Peter Clausen wrote:
> Marking the function as __must_check doesn't make much sense here. Since it
> will either return an error or the buffer length. So you'll always use the
> returned result one way or the other.
Isn't that the point of a __must_check?
This reminds me of when we added __must_check to ERR_PTR() and
PTR_ERR(). We found places that didn't check.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-12-14 14:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 10:08 [PATCH] staging:iio: Add wrapper functions around buffer access ops Lars-Peter Clausen
2011-12-13 0:45 ` Greg KH
2011-12-13 9:01 ` Lars-Peter Clausen
2011-12-13 23:59 ` Greg KH
2011-12-14 7:19 ` Jonathan Cameron
2011-12-14 10:15 ` Lars-Peter Clausen
2011-12-14 14:31 ` Dan Carpenter [this message]
2011-12-14 15:05 ` Lars-Peter Clausen
2011-12-14 16:42 ` Dan Carpenter
2011-12-14 15:49 ` Greg KH
2011-12-14 17:35 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214143144.GL3503@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).