linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Greg KH <greg@kroah.com>, Jonathan Cameron <jic23@cam.ac.uk>,
	archive@jic23.retrosnub.co.uk, linux-iio@vger.kernel.org,
	lars@metafoo.de, Linus Walleij <linus.walleij@linaro.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: Re: [PATCH 3/5] staging:iio:core add in kernel interface mapping and getting IIO channels.
Date: Thu, 22 Dec 2011 17:41:53 +0000	[thread overview]
Message-ID: <20111222174153.GD29622@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4EECBB29.8070102@kernel.org>

On Sat, Dec 17, 2011 at 03:54:17PM +0000, Jonathan Cameron wrote:
> On 12/16/2011 10:23 PM, Greg KH wrote:

> > Rewriting all probe functions really shouldn't be hard as you have to
> > just change from manipulating this list by-hand, to making a function
> > call.  That sounds like an easy thing to do, and something that should
> > be done, right?

> That plus add a level of indirection to every driver that currently
> has any platform data (which covers the vast majority).  Either
> the array of consumers has to be added to their existing pd which is
> clunky and driver specific or we have another structure with optional
> consumer data and another level of platform data to pass in what the
> driver actually cares about.  Note throughout that we are passing data
> that is completely irrelevant to the driver.  We are doing all this
> to support a usecase that isn't even relevant to many IIO drivers.

FWIW the generic platform data embed thing is what the regulator API is
currently doing, though of course we've got a bunch more data going in
there in the constraints.  This is actually a bit limiting as it means
we need to know how things are glued together at registeration time,
it'd be nice if we were able to add links in separately.

  reply	other threads:[~2011-12-22 17:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-05 21:55 [PATCH 0/5] staging:iio: inkern pull interfaces for staging tree Jonathan Cameron
2011-12-05 21:56 ` [PATCH 1/5] staging:iio: core: add datasheet_name to chan_spec Jonathan Cameron
2011-12-05 21:56 ` [PATCH 2/5] staging:iio:adc:max1363 add datasheet_name entries Jonathan Cameron
2011-12-05 21:56 ` [PATCH 3/5] staging:iio:core add in kernel interface mapping and getting IIO channels Jonathan Cameron
2011-12-08 19:40   ` Greg KH
2011-12-08 21:05     ` Jonathan Cameron
2011-12-10 17:08     ` Jonathan Cameron
2011-12-10 19:15       ` Greg KH
2011-12-16  8:50         ` archive
2011-12-16 16:24           ` Greg KH
2011-12-16 19:41             ` Jonathan Cameron
2011-12-16 22:23               ` Greg KH
2011-12-17 15:54                 ` Jonathan Cameron
2011-12-22 17:41                   ` Mark Brown [this message]
2011-12-05 21:56 ` [PATCH 4/5] staging:iio: move iio data return types into types.h for use by inkern Jonathan Cameron
2011-12-05 21:56 ` [PATCH 5/5] staging:iio::hwmon interface client driver Jonathan Cameron
  -- strict thread matches above, loose matches on Subject: below --
2011-11-27 13:13 [PATCH 0/5] IIO/staging inkernel pull interface Jonathan Cameron
2011-11-27 13:14 ` [PATCH 3/5] staging:iio:core add in kernel interface mapping and getting IIO channels Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111222174153.GD29622@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=archive@jic23.retrosnub.co.uk \
    --cc=arnd@arndb.de \
    --cc=greg@kroah.com \
    --cc=jic23@cam.ac.uk \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).