From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, greg@kroah.com,
guenter.roeck@ericsson.com, khali@linux-fr.org,
dmitry.torokhov@gmail.com, alan@lxorguk.ukuu.org.uk,
arnd@arndb.de, linus.walleij@linaro.org,
maxime.ripard@free-electrons.com,
thomas.petazzoni@free-electrons.com, zdevai@gmail.com,
w.sang@pengutronix.de, marek.vasut@gmail.com,
Jonathan Cameron <jic23@cam.ac.uk>
Subject: Re: [PATCH 5/5] stargate2: example of map configuration for iio to hwmon example.
Date: Mon, 30 Jan 2012 21:22:54 +0000 [thread overview]
Message-ID: <20120130212253.GC9672@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F26FCE2.1030705@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
On Mon, Jan 30, 2012 at 08:26:10PM +0000, Jonathan Cameron wrote:
> On 01/30/2012 07:33 PM, Mark Brown wrote:
> > On Sun, Jan 29, 2012 at 11:46:54AM +0000, Jonathan Cameron wrote:
> >> +static struct iio_map max1363_consumer_map[] = { + { +
> >> .adc_channel_label = "AIN1", + .consumer_dev =
> >> &iio_hwmon_test.dev, + .consumer_channel = "testchan1",
> > I do think it's better to use dev_name here rather than a struct
> > device pointer - for several of the buses it's not actually
> > possible to get a struct device until a device has been
> > instantiated which isn't helpful for setting up the mappings.
> We allow both. In cases like this where the dev pointer is explicitly
> available what gain do we get from not using it?
You avoid user confusion from having two ways of doing the same thing
and you save a little complexity in the implementation. The user
confusion does happen in practice.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-30 21:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-29 11:46 [RFC PATCH 0/5 V5] IIO: in kernel pull interfaces Jonathan Cameron
2012-01-29 11:46 ` [PATCH 1/5] staging:iio:core add in kernel interface mapping and getting IIO channels Jonathan Cameron
2012-01-30 20:22 ` Mark Brown
2012-01-30 20:28 ` Jonathan Cameron
2012-02-01 19:58 ` Linus Walleij
2012-02-06 21:30 ` Jonathan Cameron
2012-02-09 18:10 ` Greg KH
2012-02-09 18:34 ` Jonathan Cameron
2012-02-09 18:57 ` Greg KH
2012-02-09 19:15 ` Mark Brown
2012-02-09 19:17 ` Greg KH
2012-02-09 19:20 ` Mark Brown
2012-02-09 21:20 ` Jonathan Cameron
2012-02-10 1:03 ` Linus Walleij
2012-01-29 11:46 ` [PATCH 2/5] staging:iio: move iio data return types into types.h for use by inkern Jonathan Cameron
2012-01-29 11:46 ` [PATCH 3/5] staging:iio::hwmon interface client driver Jonathan Cameron
2012-01-29 11:46 ` [PATCH 4/5] staging:iio:Documentation in kernel pull description Jonathan Cameron
2012-01-29 11:46 ` [PATCH 5/5] stargate2: example of map configuration for iio to hwmon example Jonathan Cameron
2012-01-30 19:33 ` Mark Brown
2012-01-30 20:26 ` Jonathan Cameron
2012-01-30 21:22 ` Mark Brown [this message]
2012-01-30 21:48 ` Jonathan Cameron
2012-01-31 8:39 ` Linus Walleij
2012-01-31 11:09 ` Mark Brown
2012-01-30 19:28 ` [RFC PATCH 0/5 V5] IIO: in kernel pull interfaces Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2011-11-07 15:44 [PATCH 0/5 V4] IIO in kernel interfaces (pull) Jonathan Cameron
2011-11-07 15:44 ` [PATCH 5/5] stargate2: example of map configuration for iio to hwmon example Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130212253.GC9672@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=greg@kroah.com \
--cc=guenter.roeck@ericsson.com \
--cc=jic23@cam.ac.uk \
--cc=jic23@kernel.org \
--cc=khali@linux-fr.org \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=maxime.ripard@free-electrons.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=w.sang@pengutronix.de \
--cc=zdevai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).