From: Wolfram Sang <w.sang@pengutronix.de>
To: Roland Stigge <stigge@antcom.de>
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
kevin.wells@nxp.com, jic23@cam.ac.uk
Subject: Re: [PATCH v2] ARM: LPC32xx: ADC support
Date: Tue, 14 Feb 2012 18:09:31 +0100 [thread overview]
Message-ID: <20120214170931.GA2523@pengutronix.de> (raw)
In-Reply-To: <1329077345-15305-1-git-send-email-stigge@antcom.de>
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
On Sun, Feb 12, 2012 at 09:09:05PM +0100, Roland Stigge wrote:
> This patch adds a 3-channel ADC driver for the LPC32xx ARM SoC
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>
You need to split the mach-specific stuff and the driver, then submit
them seperately via the respective maintainers.
> Index: linux-arm-soc/arch/arm/mach-lpc32xx/phy3250.c
> ===================================================================
> --- linux-arm-soc.orig/arch/arm/mach-lpc32xx/phy3250.c 2012-02-12 20:04:49.000000000 +0100
> +++ linux-arm-soc/arch/arm/mach-lpc32xx/phy3250.c 2012-02-12 20:17:13.000000000 +0100
> @@ -252,6 +252,9 @@
> &lpc32xx_i2c2_device,
> &lpc32xx_watchdog_device,
> &lpc32xx_gpio_led_device,
> +#if defined(CONFIG_LPC32XX_ADC)
> + &lpc32xx_adc_device,
> +#endif
Probably personal taste, yet I'd skip the #ifdef.
The rest of the mach stuff looks fine to me.
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2012-02-14 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-12 20:09 [PATCH v2] ARM: LPC32xx: ADC support Roland Stigge
2012-02-12 20:27 ` Roland Stigge
2012-02-14 14:56 ` Jonathan Cameron
2012-02-14 17:09 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120214170931.GA2523@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=devel@driverdev.osuosl.org \
--cc=jic23@cam.ac.uk \
--cc=kevin.wells@nxp.com \
--cc=linux-iio@vger.kernel.org \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).