From: Dan Carpenter <dan.carpenter@oracle.com>
To: Grant Grundler <grundler@chromium.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
devel@driverdev.osuosl.org, linux-iio@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Bryan Freed <bfreed@chromium.org>,
Jonathan Cameron <jic23@cam.ac.uk>,
Benson Leung <bleung@chromium.org>
Subject: Re: [PATCH] staging:iio:tsl2563 rewrite probe error handling
Date: Fri, 9 Mar 2012 09:23:58 +0300 [thread overview]
Message-ID: <20120309062358.GA3337@mwanda> (raw)
In-Reply-To: <CANEJEGvWm83ucH8RH5HK_otTae2AxpUsvLV1XDA9=-JOL1kMGQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 923 bytes --]
On Thu, Mar 08, 2012 at 07:51:07PM -0800, Grant Grundler wrote:
> Hi Jonathan!
>
> On Wed, Mar 7, 2012 at 3:28 AM, Jonathan Cameron <jic23@kernel.org> wrote:
> > Fundamentally an excellent patch fixing some real issues,
>
> Thank you! :)
>
> > but just
> > because I'm in that sort of mood I'll be fussy about the fact it is
> > one patch.
> >
> > To nitpick, I'd have prefered this to be two patches. First that fixes
> > the issues and the second that adds the additional output. Actually
> > should probably have even had a third making the white space changes.
>
> Yup - I see/understand why. I need to improve my git foo and work
> habits so it's not hard to play with a series of smaller patches
> rather than one patch that does everything to one function.
>
If you use git citool then you can just highlight and right click on
the lines you want to merge.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-03-09 6:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 17:15 [PATCH] staging:iio:tsl2563 rewrite probe error handling Grant Grundler
2012-03-05 21:27 ` Benson Leung
2012-03-05 22:12 ` Grant Grundler
2012-03-05 21:28 ` Benson Leung
2012-03-05 21:53 ` Bryan Freed
2012-03-05 22:12 ` Grant Grundler
2012-03-05 21:55 ` Bryan Freed
2012-03-07 11:28 ` Jonathan Cameron
2012-03-09 3:51 ` Grant Grundler
2012-03-09 6:23 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120309062358.GA3337@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bfreed@chromium.org \
--cc=bleung@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=grundler@chromium.org \
--cc=jic23@cam.ac.uk \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).