From: Dan Carpenter <dan.carpenter@oracle.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: jic23@cam.ac.uk, gregkh@linuxfoundation.org,
grant.likely@secretlab.ca, rob.herring@calxeda.com,
jbrenner@taosinc.com, rklein@nvidia.com, max@stro.at,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/2] staging: iio: add driver for isl29028
Date: Thu, 12 Apr 2012 10:35:54 +0300 [thread overview]
Message-ID: <20120412073554.GA6498@mwanda> (raw)
In-Reply-To: <1334214492-23044-2-git-send-email-ldewangan@nvidia.com>
On Thu, Apr 12, 2012 at 12:38:11PM +0530, Laxman Dewangan wrote:
> Intersil's ISL29028 is concurrent Ambient Light and
> Proximity Sensor device.
> Add driver to access the light and IR intensity and
> proximity value via iio interface.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> Taken care of all review comment from Dan.
Looks nice. You went above and beyond and cleaned up a couple
things I didn't mention. Thanks.
regards,
dan carpenter
next prev parent reply other threads:[~2012-04-12 7:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 7:08 [PATCH V2 0/2] staging: iio: add isl29028 driver Laxman Dewangan
2012-04-12 7:08 ` [PATCH V2 1/2] staging: iio: add driver for isl29028 Laxman Dewangan
2012-04-12 7:35 ` Dan Carpenter [this message]
2012-04-12 9:32 ` Jonathan Cameron
2012-04-12 7:08 ` [PATCH V2 2/2] staging: Documentation: add proximity_sampling_period as sysfs details Laxman Dewangan
2012-04-12 9:37 ` Jonathan Cameron
2012-04-12 9:48 ` Laxman Dewangan
2012-04-12 10:01 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120412073554.GA6498@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=jbrenner@taosinc.com \
--cc=jic23@cam.ac.uk \
--cc=ldewangan@nvidia.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@stro.at \
--cc=rklein@nvidia.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).