From: Dan Carpenter <dan.carpenter@oracle.com>
To: joseph daniel <josephdanielwalter@gmail.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wolfram Sang <w.sang@pengutronix.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/iio/meter: fix the coding style problem
Date: Mon, 30 Apr 2012 23:04:44 +0300 [thread overview]
Message-ID: <20120430200444.GM6447@mwanda> (raw)
In-Reply-To: <1335813977-8096-1-git-send-email-josephdanielwalter@gmail.com>
On Tue, May 01, 2012 at 01:26:17AM +0600, joseph daniel wrote:
>
> Signed-off-by: joseph daniel <josephdanielwalter@gmail.com>
> ---
> Hi Lars,
> Thanks for review. how about the below change?
Slow down. There is no rush. It's better to sit on patches
overnight so you can review them carefully the next day. Take the
time to write a proper changelog...
> drivers/staging/iio/meter/ade7854-i2c.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
> index 1e1faa0..52bdb05 100644
> --- a/drivers/staging/iio/meter/ade7854-i2c.c
> +++ b/drivers/staging/iio/meter/ade7854-i2c.c
> @@ -181,6 +181,7 @@ static int ade7854_i2c_read_reg_32(struct device *dev,
> {
> struct iio_dev *indio_dev = dev_get_drvdata(dev);
> struct ade7854_state *st = iio_priv(indio_dev);
> + uint32_t value;
Use the endian notation here:
__be32 value;
http://lwn.net/Articles/205624/
The rest looks fine to me. Package it up like a proper patch and
resend.
regards,
dan carpenter
next prev parent reply other threads:[~2012-04-30 20:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 19:26 [PATCH] staging/iio/meter: fix the coding style problem joseph daniel
2012-04-30 20:01 ` Lars-Peter Clausen
2012-05-01 4:08 ` joseph daniel
2012-05-01 7:56 ` Jonathan Cameron
2012-05-01 8:50 ` Lars-Peter Clausen
2012-04-30 20:04 ` Dan Carpenter [this message]
2012-04-30 20:18 ` Dan Carpenter
2012-05-01 4:09 ` joseph daniel
-- strict thread matches above, loose matches on Subject: below --
2012-04-30 18:21 joseph daniel
2012-04-30 18:32 ` Lars-Peter Clausen
2012-04-30 18:12 joseph daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120430200444.GM6447@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@cam.ac.uk \
--cc=josephdanielwalter@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).