From: Dan Carpenter <dan.carpenter@oracle.com>
To: joseph daniel <josephdanielwalter@gmail.com>
Cc: devel@driverdev.osuosl.org, Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wolfram Sang <w.sang@pengutronix.de>,
linux-kernel@vger.kernel.org,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Jonathan Cameron <jic23@cam.ac.uk>
Subject: Re: [PATCH] staging/iio/meter: fix the coding style problem
Date: Mon, 30 Apr 2012 23:18:56 +0300 [thread overview]
Message-ID: <20120430201855.GN6447@mwanda> (raw)
In-Reply-To: <20120430200444.GM6447@mwanda>
On Mon, Apr 30, 2012 at 11:04:44PM +0300, Dan Carpenter wrote:
> On Tue, May 01, 2012 at 01:26:17AM +0600, joseph daniel wrote:
> >
> > Signed-off-by: joseph daniel <josephdanielwalter@gmail.com>
> > ---
> > Hi Lars,
> > Thanks for review. how about the below change?
Lar's review is the correct one. It's cleaner to use
get_unaligned_be32(). You'll need to include <asm/unaligned.h>
regards,
dan carpenter
next prev parent reply other threads:[~2012-04-30 20:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 19:26 [PATCH] staging/iio/meter: fix the coding style problem joseph daniel
2012-04-30 20:01 ` Lars-Peter Clausen
2012-05-01 4:08 ` joseph daniel
2012-05-01 7:56 ` Jonathan Cameron
2012-05-01 8:50 ` Lars-Peter Clausen
2012-04-30 20:04 ` Dan Carpenter
2012-04-30 20:18 ` Dan Carpenter [this message]
2012-05-01 4:09 ` joseph daniel
-- strict thread matches above, loose matches on Subject: below --
2012-04-30 18:21 joseph daniel
2012-04-30 18:32 ` Lars-Peter Clausen
2012-04-30 18:12 joseph daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120430201855.GN6447@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@cam.ac.uk \
--cc=josephdanielwalter@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).