From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] iio:dac:ad5449: unlock on error path
Date: Wed, 24 Oct 2012 10:13:07 +0300 [thread overview]
Message-ID: <20121024071307.GC2536@elgon.mountain> (raw)
There is an unlock missing on this error path.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Only needed in linux-next.
diff --git a/drivers/iio/dac/ad5449.c b/drivers/iio/dac/ad5449.c
index 5b43030..0ee6f8e 100644
--- a/drivers/iio/dac/ad5449.c
+++ b/drivers/iio/dac/ad5449.c
@@ -124,12 +124,13 @@ static int ad5449_read(struct iio_dev *indio_dev, unsigned int addr,
ret = spi_sync(st->spi, &msg);
if (ret < 0)
- return ret;
+ goto out_unlock;
*val = be16_to_cpu(st->data[1]);
- mutex_unlock(&indio_dev->mlock);
- return 0;
+out_unlock:
+ mutex_unlock(&indio_dev->mlock);
+ return ret;
}
static int ad5449_read_raw(struct iio_dev *indio_dev,
next reply other threads:[~2012-10-24 7:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 7:13 Dan Carpenter [this message]
2012-10-24 8:22 ` [patch] iio:dac:ad5449: unlock on error path Lars-Peter Clausen
2012-11-02 11:06 ` Jonathan Cameron
2012-11-02 16:52 ` walter harms
2012-11-05 6:38 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024071307.GC2536@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=jic23@cam.ac.uk \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).