From: Guenter Roeck <linux@roeck-us.net>
To: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>
Cc: devicetree-discuss@lists.ozlabs.org,
Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Doug Anderson <dianders@chromium.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Anton Vorontsov <cbou@mail.ru>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v3 2/2] iio: Add OF support
Date: Tue, 5 Feb 2013 07:22:19 -0800 [thread overview]
Message-ID: <20130205152219.GA15057@roeck-us.net> (raw)
In-Reply-To: <1360009566-26347-3-git-send-email-linux@roeck-us.net>
On Mon, Feb 04, 2013 at 12:26:06PM -0800, Guenter Roeck wrote:
> Provide bindings and parse OF data during initialization.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> One open question is how to assign of_node to the iio device. We can either do it
> in each driver (which turns out to be a huge patchset), or add something like the
> following to iio_device_register.
>
> if (!indio_dev->dev.of_node && indio_dev->dev.parent)
> indio_dev->dev.of_node = indio_dev->dev.parent->of_node;
>
[ ... ]
> +
> +#else /* CONFIG_OF */
> +
> +static inline struct iio_channel *
> +of_iio_channel_get_by_name(struct device *dev, const char *name)
> +{
> + return ERR_PTR(-ENOENT);
> +}
> +
The above should be
static inline struct iio_channel *
of_iio_channel_get_by_name(struct device_node *np, const char *name)
{
return NULL;
}
Will be fixed in the next version.
Guenter
next prev parent reply other threads:[~2013-02-05 15:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 20:26 [PATCH v3 0/2] iio: Devicetree support Guenter Roeck
2013-02-04 20:26 ` [PATCH 1/2] iio: Update iio_channel_get API to use consumer device pointer as argument Guenter Roeck
2013-02-04 21:38 ` Anton Vorontsov
2013-02-04 23:57 ` Chanwoo Choi
2013-02-06 19:30 ` Jonathan Cameron
2013-02-04 20:26 ` [PATCH v3 2/2] iio: Add OF support Guenter Roeck
2013-02-05 5:20 ` Guenter Roeck
2013-02-05 15:22 ` Guenter Roeck [this message]
2013-02-06 18:29 ` [PATCH v4 " Guenter Roeck
2013-02-06 19:37 ` Jonathan Cameron
2013-02-06 20:05 ` Guenter Roeck
2013-02-06 20:12 ` Tomasz Figa
2013-02-07 1:53 ` Guenter Roeck
2013-02-07 9:00 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205152219.GA15057@roeck-us.net \
--to=linux@roeck-us.net \
--cc=cbou@mail.ru \
--cc=ch.naveen@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dianders@chromium.org \
--cc=dwmw2@infradead.org \
--cc=grant.likely@secretlab.ca \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rob.herring@calxeda.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox