From: Marek Vasut <marex@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: jic23@cam.ac.uk, linux-iio@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] iio: mxs-lradc: Fix 'duplicate const' warning
Date: Wed, 6 Feb 2013 03:59:51 +0100 [thread overview]
Message-ID: <201302060359.51912.marex@denx.de> (raw)
In-Reply-To: <1360119284-28726-1-git-send-email-festevam@gmail.com>
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> The following warning is generated by sparse:
>
> drivers/staging/iio/adc/mxs-lradc.c:118:47: warning: duplicate const
>
> Remove the duplicate const.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/staging/iio/adc/mxs-lradc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
> b/drivers/staging/iio/adc/mxs-lradc.c index 33a2747..55a459b 100644
> --- a/drivers/staging/iio/adc/mxs-lradc.c
> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> @@ -115,7 +115,7 @@ struct mxs_lradc_of_config {
> const char * const *irq_name;
> };
>
> -static const struct mxs_lradc_of_config const mxs_lradc_of_config[] = {
> +static const struct mxs_lradc_of_config mxs_lradc_of_config[] = {
> [IMX23_LRADC] = {
> .irq_count = ARRAY_SIZE(mx23_lradc_irq_names),
> .irq_name = mx23_lradc_irq_names,
Isn't it const variable/array const array elements ... thus correct with the two
consts ?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-02-06 2:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 2:54 [PATCH] iio: mxs-lradc: Fix 'duplicate const' warning Fabio Estevam
2013-02-06 2:59 ` Marek Vasut [this message]
2013-02-06 18:37 ` Jonathan Cameron
2013-02-09 10:52 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302060359.51912.marex@denx.de \
--to=marex@denx.de \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox