From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michael Hennerich <michael.hennerich@analog.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: iio: frequency: New driver for Analog Devices ADF4350/ADF4351 Wideband Synthesizers
Date: Thu, 23 May 2013 12:15:30 +0300 [thread overview]
Message-ID: <20130523091530.GF30128@mwanda> (raw)
In-Reply-To: <519DD204.4040807@analog.com>
On Thu, May 23, 2013 at 10:23:32AM +0200, Michael Hennerich wrote:
> Thanks for the reminder.
> We actually fixed the typo in the mask some time ago,
> 0x9 should be 0x3, we send a patch shortly.
>
> 7 or 3 being signed by default shouldn't matter. The whole term
> at the end is just a big mask used to reject some bits being
> set in r2_user_settings.
It's truncated away, yes. But sign extension from int literals is
an easy thing for the static checkers to spot and it's upsets and
worries them. Let's fix that as well, I would do it but it's an
awkward thing because I have to wait for your first patch and then
write a patch on top of that...
regards,
dan carpenter
prev parent reply other threads:[~2013-05-23 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 20:25 iio: frequency: New driver for Analog Devices ADF4350/ADF4351 Wideband Synthesizers Dan Carpenter
2013-05-23 8:23 ` Michael Hennerich
2013-05-23 9:15 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523091530.GF30128@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox