From: Marek Vasut <marex@denx.de>
To: Hector Palacios <hector.palacios@digi.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
alexandre.belloni@free-electrons.com, jic23@kernel.org,
lars@metafoo.de, fabio.estevam@freescale.com
Subject: Re: [PATCH v2 1/5] iio: mxs-lradc: change the realbits to 12
Date: Fri, 19 Jul 2013 15:56:46 +0200 [thread overview]
Message-ID: <201307191556.46857.marex@denx.de> (raw)
In-Reply-To: <1374225208-28940-2-git-send-email-hector.palacios@digi.com>
Dear Hector Palacios,
> The LRADC virtual channels have an 18 bit field to store the sum of up
> to 2^5 accumulated samples. The read_raw function however only operates
> over a single sample (12 bit resolution).
> In order to use this field for scaling operations, we need it to be the
> exact resolution value of the LRADC.
> Besides, the driver was using an 18 bit mask (LRADC_CH_VALUE_MASK) to
> report touch coordinates to userland. A 12 bit mask should be used instead
> or else the touch libraries will expect a coordinates range between 0
> and 0x3ffff (18 bits), instead of between 0 and 0xfff (12 bits).
>
> Signed-off-by: Hector Palacios <hector.palacios@digi.com>
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-07-19 13:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 9:13 [PATCH v2 0/5] iio: mxs-lradc: add support to optional divider_by_two Hector Palacios
2013-07-19 9:13 ` [PATCH v2 1/5] iio: mxs-lradc: change the realbits to 12 Hector Palacios
2013-07-19 13:56 ` Marek Vasut [this message]
2013-07-19 17:09 ` Alexandre Belloni
2013-07-19 9:13 ` [PATCH v2 2/5] ARM: dts: add reference voltage property for MXS LRADC Hector Palacios
2013-07-19 13:58 ` Marek Vasut
2013-07-19 17:10 ` Alexandre Belloni
2013-07-19 9:13 ` [PATCH v2 3/5] iio: mxs-lradc: add scale attribute to channels Hector Palacios
2013-07-19 14:30 ` Marek Vasut
2013-07-19 15:44 ` Hector Palacios
2013-07-19 16:14 ` Marek Vasut
2013-07-22 7:22 ` Hector Palacios
2013-07-22 7:42 ` Marek Vasut
2013-07-22 7:46 ` Hector Palacios
2013-07-22 7:58 ` Marek Vasut
2013-07-19 17:06 ` Alexandre Belloni
2013-07-22 7:26 ` Hector Palacios
2013-07-19 9:13 ` [PATCH v2 4/5] iio: mxs-lradc: add scale_available file " Hector Palacios
2013-07-19 17:20 ` Alexandre Belloni
2013-07-19 9:13 ` [PATCH v2 5/5] iio: mxs-lradc: add write_raw function to modify scale Hector Palacios
2013-07-19 14:39 ` Marek Vasut
2013-07-19 15:31 ` Hector Palacios
2013-07-19 16:17 ` Marek Vasut
2013-07-19 16:22 ` Hector Palacios
2013-07-19 20:23 ` Jonathan Cameron
2013-07-20 19:00 ` Marek Vasut
2013-07-19 20:32 ` Jonathan Cameron
2013-07-22 8:01 ` Hector Palacios
2013-07-19 17:21 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201307191556.46857.marex@denx.de \
--to=marex@denx.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=fabio.estevam@freescale.com \
--cc=hector.palacios@digi.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).