From: Lee Jones <lee.jones@linaro.org>
To: Mark Rutland <mark.rutland@arm.com>, sa@the-dreams.de
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jic23@cam.ac.uk" <jic23@cam.ac.uk>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] Documentation: dt: i2c: Add LPS001WP to the Trivial Devices list
Date: Wed, 4 Sep 2013 16:11:59 +0100 [thread overview]
Message-ID: <20130904151159.GA8980@lee--X1> (raw)
In-Reply-To: <20130904142422.GM18206@e106331-lin.cambridge.arm.com>
> Cheers for producing a binding.
>
> On Wed, Sep 04, 2013 at 02:50:55PM +0100, Lee Jones wrote:
> > LPS001WP is a Pressure and Temperature sensor.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> > index ad6a738..6038807e6 100644
> > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> > @@ -57,6 +57,7 @@ st-micro,24c256 i2c serial eeprom (24cxx)
> > stm,m41t00 Serial Access TIMEKEEPER
> > stm,m41t62 Serial real-time clock (RTC) with alarm
> > stm,m41t80 M41T80 - SERIAL ACCESS RTC WITH ALARMS
> > +stm,lps001wp Pressure and Temperature sensor
>
> As I hinted at in the other thread [1], I don't think this can be
> documented as a trivial binding -- the driver expects a couple of
> regulators which should be described in the binding (or the driver
> shouldn't be using them...).
Surely all devices need to be powered and would subsequently require a
regulator of one description or other? We don't really *need* to
manually enable it on my platform but that's because it's 'always
on', but we do anyway for completeness.
Would a (regulator: vdd) note in this patch be suitable? It seems a
shame to have to produce a boilerplate binding entry for the sake of a
regulator.
Wolfram, what's the common procedure in cases such as these?
> Also, in the other thread the "st," prefix was used [2], while "stm," is
> listed at the prefix in the binding. As far as I can see, "st," should
> be used, as it's in vendor-prefixes and "stm," is not.
>
> I'm happy to cook up a patch adding deprecation notes and corrected
> strings for the existing incorrect "stm," bindings.
Sure, feel free.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-09-04 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 13:50 [PATCH] Documentation: dt: i2c: Add LPS001WP to the Trivial Devices list Lee Jones
2013-09-04 14:24 ` Mark Rutland
2013-09-04 15:11 ` Lee Jones [this message]
2013-09-04 16:33 ` Lee Jones
2013-09-05 11:30 ` Mark Rutland
2013-09-05 11:40 ` Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904151159.GA8980@lee--X1 \
--to=lee.jones@linaro.org \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=sa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).