From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 22 Sep 2013 19:51:46 +0200 From: Matthias Kaehlcke To: Jonathan Cameron Cc: Jonathan Cameron , Sebastian Andrzej Siewior , Felipe Balbi , Pantelis Antoniou , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Arun Joseph Subject: Re: [PATCH v2] iio: ti_am335x_adc: Take touchscreen steps into account for conversion timeout Message-ID: <20130922175145.GB27515@raspi> References: <20130916211749.GG24058@raspi> <523D9046.7010305@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <523D9046.7010305@kernel.org> List-ID: Hi, El Sat, Sep 21, 2013 at 01:25:42PM +0100 Jonathan Cameron ha dit: > On 09/16/13 22:17, Matthias Kaehlcke wrote: > > The calculation of the old conversion timeout value was based on the number of > > steps used by this driver. This doesn't take into account that other steps > > can be used by the touchscreen driver. Select the timeout value based on the > > steps used by both drivers > > > > Signed-off-by: Matthias Kaehlcke > Looks fine to me but I'd like an Ack from someone more familiar with the device > if possible. Arun, do you feel entitled to Ack or can you suggest someone from TI who is? > Also, I'm assuming this is a fix we want to push out asap but that isn't > clear in your patch title. Perhaps something like: > > iio: ti_am335x_adc: Fix conversion timeout to allow for touch screen steps. > ? it's not as critical as it seems as in practice the timeout has the granularity of a jiffy. If you prefer I still can resend the patch with the subject you suggest best regards -- Matthias Kaehlcke Embedded Linux Developer Amsterdam If God had not intended for us to eat animals, how come He made them out of meat? (Sarah Palin) .''`. using free software / Debian GNU/Linux | http://debian.org : :' : `. `'` gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-