From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, kernel@savoirfairelinux.com
Subject: max1363: internal reference
Date: Thu, 9 Jan 2014 12:39:42 -0500 (EST) [thread overview]
Message-ID: <2013486580.319791.1389289182921.JavaMail.root@mail> (raw)
In-Reply-To: <235056967.112251.1389282903427.JavaMail.root@mail>
Hi Jonathan,
As described in the max1363.c header, the control of the internal
reference is not currently supported by the driver.
We have two max11603 and max11605 which need this option. We currently
use a monkey patch like this in max1363.c:
@@ -1414,7 +1414,12 @@ static const struct max1363_chip_info ma
static int max1363_initial_setup(struct max1363_state *st)
{
+#ifdef OUR_BOARD
+ st->setupbyte = MAX1363_SETUP_AIN3_IS_AIN3_REF_IS_INT
+#else
st->setupbyte = MAX1363_SETUP_AIN3_IS_AIN3_REF_IS_VDD
+#endif
| MAX1363_SETUP_POWER_UP_INT_REF
| MAX1363_SETUP_INT_CLOCK
| MAX1363_SETUP_UNIPOLAR
In order to add the support for this, I would suggest adding a
platform_data for this driver such as:
struct max1363_platform_data {
bool internal_reference;
};
What do you think?
Best,
Vivien
next parent reply other threads:[~2014-01-09 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <235056967.112251.1389282903427.JavaMail.root@mail>
2014-01-09 17:39 ` Vivien Didelot [this message]
2014-01-10 9:27 ` max1363: internal reference Lars-Peter Clausen
2014-01-10 20:00 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2013486580.319791.1389289182921.JavaMail.root@mail \
--to=vivien.didelot@savoirfairelinux.com \
--cc=jic23@kernel.org \
--cc=kernel@savoirfairelinux.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).