* [PATCH] staging:iio:ad2s1210 fix a leak when device removed
@ 2014-04-29 5:55 Jimmy Li
2014-04-29 6:07 ` Jingoo Han
0 siblings, 1 reply; 3+ messages in thread
From: Jimmy Li @ 2014-04-29 5:55 UTC (permalink / raw)
To: Jonathan Cameron, Greg Kroah-Hartman, Jingoo Han,
Lars-Peter Clausen, Sachin Kamat, Monam Agarwal
Cc: linux-iio, devel, linux-kernel
Signed-off-by: Jimmy Li <coder.liss@gmail.com>
---
drivers/staging/iio/resolver/ad2s1210.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
index 7fbaba4..3d6e123 100644
--- a/drivers/staging/iio/resolver/ad2s1210.c
+++ b/drivers/staging/iio/resolver/ad2s1210.c
@@ -716,6 +716,7 @@ static int ad2s1210_remove(struct spi_device *spi)
iio_device_unregister(indio_dev);
ad2s1210_free_gpios(iio_priv(indio_dev));
+ devm_iio_device_free(&spi->dev, indio_dev);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging:iio:ad2s1210 fix a leak when device removed
2014-04-29 5:55 [PATCH] staging:iio:ad2s1210 fix a leak when device removed Jimmy Li
@ 2014-04-29 6:07 ` Jingoo Han
2014-04-29 6:29 ` Jimmy Li
0 siblings, 1 reply; 3+ messages in thread
From: Jingoo Han @ 2014-04-29 6:07 UTC (permalink / raw)
To: 'Jimmy Li'
Cc: 'Jonathan Cameron', 'Greg Kroah-Hartman',
'Lars-Peter Clausen', 'Sachin Kamat',
'Monam Agarwal', linux-iio, devel, linux-kernel,
'Jingoo Han'
On Tuesday, April 29, 2014 2:56 PM, Jimmy Li wrote:
>
> Signed-off-by: Jimmy Li <coder.liss@gmail.com>
> ---
> drivers/staging/iio/resolver/ad2s1210.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> index 7fbaba4..3d6e123 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -716,6 +716,7 @@ static int ad2s1210_remove(struct spi_device *spi)
>
> iio_device_unregister(indio_dev);
> ad2s1210_free_gpios(iio_priv(indio_dev));
> + devm_iio_device_free(&spi->dev, indio_dev);
NAK.
In ad2s1210_probe(),devm_iio_device_alloc() was already used.
So, when ad2s1210_remove() is called, iio_device_free() will
be called automatically. So, the leak never happens.
If you want to know about devm_* functions, please refer
to the following.
Documentation/driver-model/devres.txt
Best regards,
Jingoo Han
>
> return 0;
> }
> --
> 1.7.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging:iio:ad2s1210 fix a leak when device removed
2014-04-29 6:07 ` Jingoo Han
@ 2014-04-29 6:29 ` Jimmy Li
0 siblings, 0 replies; 3+ messages in thread
From: Jimmy Li @ 2014-04-29 6:29 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Jonathan Cameron', 'Greg Kroah-Hartman',
'Lars-Peter Clausen', 'Sachin Kamat',
'Monam Agarwal', linux-iio, devel, linux-kernel
On Tue, Apr 29, 2014 at 03:07:04PM +0900, Jingoo Han wrote:
> On Tuesday, April 29, 2014 2:56 PM, Jimmy Li wrote:
> >
> > Signed-off-by: Jimmy Li <coder.liss@gmail.com>
> > ---
> > drivers/staging/iio/resolver/ad2s1210.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> > index 7fbaba4..3d6e123 100644
> > --- a/drivers/staging/iio/resolver/ad2s1210.c
> > +++ b/drivers/staging/iio/resolver/ad2s1210.c
> > @@ -716,6 +716,7 @@ static int ad2s1210_remove(struct spi_device *spi)
> >
> > iio_device_unregister(indio_dev);
> > ad2s1210_free_gpios(iio_priv(indio_dev));
> > + devm_iio_device_free(&spi->dev, indio_dev);
>
> NAK.
>
> In ad2s1210_probe(),devm_iio_device_alloc() was already used.
> So, when ad2s1210_remove() is called, iio_device_free() will
> be called automatically. So, the leak never happens.
>
> If you want to know about devm_* functions, please refer
> to the following.
>
> Documentation/driver-model/devres.txt
Thank you for your reply,
I understand it now, just ignore this patch.
>
> Best regards,
> Jingoo Han
> >
> > return 0;
> > }
> > --
> > 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-29 6:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-29 5:55 [PATCH] staging:iio:ad2s1210 fix a leak when device removed Jimmy Li
2014-04-29 6:07 ` Jingoo Han
2014-04-29 6:29 ` Jimmy Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).