From: Sebastian Reichel <sre@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Paul Kocialkowski <contact@paulk.fr>,
linux-iio@vger.kernel.org, j-keerthy@ti.com
Subject: Re: [PATCH] twl4030-madc: Request processed values in twl4030_get_madc_conversion
Date: Mon, 2 Jun 2014 20:10:40 +0200 [thread overview]
Message-ID: <20140602181039.GA2185@earth.universe> (raw)
In-Reply-To: <538CBBA6.30203@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
Hi,
On Mon, Jun 02, 2014 at 07:00:06PM +0100, Jonathan Cameron wrote:
> On 24/05/14 13:09, Paul Kocialkowski wrote:
> >Not setting the raw parameter in the request causes it to be randomly
> >initialized to a value that might be different from zero or zero. This leads to
> >values that are randomly either raw or processed, making it very difficult to
> >make reliable use of the values.
> >
> >Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>
> This one seems obvious enough to me that I've applied it to the fixes-togreg
> branch. Note you should cc the author or if the log makes it clear someone
> else has been working with the driver recently, then cc them.
> In this case Sebastian.
The commit message looks a bit odd "[...] different from zero or
zero". In case this is still relevant:
Acked-By: Sebastian Reichel <sre@kernel.org>
> [...]
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-06-02 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 12:09 [PATCH] twl4030-madc: Request processed values in twl4030_get_madc_conversion Paul Kocialkowski
2014-06-02 18:00 ` Jonathan Cameron
2014-06-02 18:10 ` Sebastian Reichel [this message]
2014-06-02 19:17 ` Paul Kocialkowski
2014-06-02 20:56 ` Jonathan Cameron
2014-06-02 20:54 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602181039.GA2185@earth.universe \
--to=sre@kernel.org \
--cc=contact@paulk.fr \
--cc=j-keerthy@ti.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).