From: Mark Rutland <mark.rutland@arm.com>
To: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: "linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"naveenkrishna.ch@gmail.com" <naveenkrishna.ch@gmail.com>,
"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"cpgs@samsung.com" <cpgs@samsung.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 1/4] devicetree: bindings: Document murata vendor prefix
Date: Tue, 24 Jun 2014 14:30:30 +0100 [thread overview]
Message-ID: <20140624133030.GH5856@leverpostej> (raw)
In-Reply-To: <1403612356-23685-2-git-send-email-ch.naveen@samsung.com>
On Tue, Jun 24, 2014 at 01:19:13PM +0100, Naveen Krishna Chatradhi wrote:
> Add Murata Manufacturing Co., Ltd. to the list of device tree
> vendor prefixes.
>
> Murata manufactures NTC (Negative Temperature Coefficient) based
> Thermistors for small scale applications like Mobiles and PDAs.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> ---
> This changes is needed for the following reasons
>
> 1. The vendor prefix "ntc" is not defined in vendor-prefixes.txt
> Thus, giving an error when checked with scripts/checkpatch.pl
> 2. Murata Manufacturing Co., Ltd. Is the vendor for the
> NTC (Negative Temperature Coefficient) based thermistors.
> Hence, "murata" is the right vendor-prefix, Not "ntc".
> 3. NTC is a technology used, But the prefix "ntc" is wrongly
> and heavily used in the driver and the documentation.
>
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 4d7f375..a39b7d7 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -84,6 +84,7 @@ moxa Moxa
> mpl MPL AG
> mundoreader Mundo Reader S.L.
> mxicy Macronix International Co., Ltd.
> +murata Murata Manufacturing Co., Ltd.
Nit: please keep this list in alphabetical order.
Otherwise, this looks fine to me. With the order fixed:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> national National Semiconductor
> neonode Neonode Inc.
> netgear NETGEAR
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-06-24 13:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 12:19 [PATCH 0/4] hwmon: ntc_thermistor: prepose vendor prefix change Naveen Krishna Chatradhi
2014-06-24 12:19 ` [PATCH 1/4] devicetree: bindings: Document murata vendor prefix Naveen Krishna Chatradhi
2014-06-24 13:30 ` Mark Rutland [this message]
2014-06-24 13:38 ` Naveen Krishna Ch
2014-06-24 12:19 ` [PATCH 2/4] hwmon: ntc_thermistor: Use the manufacturer name properly Naveen Krishna Chatradhi
2014-06-24 13:32 ` Mark Rutland
2014-06-24 13:40 ` Naveen Krishna Ch
2014-06-24 12:19 ` [PATCH 3/4] ARM: DTS: use new compatible string as per the documentation Naveen Krishna Chatradhi
2014-06-24 13:33 ` Mark Rutland
2014-06-24 13:41 ` Naveen Krishna Ch
2014-06-24 12:19 ` [PATCH 4/4] ARM: DTS: Add NTC thermistor nodes as child nodes to ADC Naveen Krishna Chatradhi
2014-06-24 21:54 ` Doug Anderson
2014-06-25 5:04 ` Naveen Krishna Ch
2014-06-25 7:37 ` Javier Martinez Canillas
2014-06-25 17:00 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140624133030.GH5856@leverpostej \
--to=mark.rutland@arm.com \
--cc=ch.naveen@samsung.com \
--cc=cpgs@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=naveenkrishna.ch@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).