From: Michael Welling <mwelling@ieee.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guillaume Morin <guillaume@morinfr.org>,
Jonathan Cameron <jic23@kernel.org>,
Sachin Kamat <sachin.kamat@linaro.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] staging: iio: ad9850.c: fix checkpatch.pl error
Date: Sat, 28 Jun 2014 02:00:41 -0500 [thread overview]
Message-ID: <20140628070041.GA3846@deathray> (raw)
In-Reply-To: <20140628031045.GA13985@bender.morinfr.org>
Looking at the driver the define you are fixing isn't even used.
So it could be removed.
While you are at it you may want to remove the peice of completey
redundant code.
.
.
if (ret)
goto error_ret;
error_ret:
.
.
Wow.
On Sat, Jun 28, 2014 at 05:10:46AM +0200, Guillaume Morin wrote:
> On 27 Jun 22:37, Greg Kroah-Hartman wrote:
> > Put that below the --- line.
>
> Will do.
>
> > > > And what checkpatch error did you fix? And are you sure it needs to be
> > > > fixed?
> > >
> > > That's what I changed:
> > >
> > > $ scripts/checkpatch.pl -f drivers/staging/iio/frequency/ad9850.c
> > > ERROR: Macros with complex values should be enclosed in parenthesis
> >
> > Then why didn't you say that :)
>
> Well it was not totally clear to me if that was obvious or not. Anyway,
> I'll mention it in the future.
>
> >
> > > I assumed that if it was reported as an error, it needed to be fixed...
> >
> > Use your judgement, checkpatch is a tool, it isn't always correct.
>
> Right, I guess it's borderline. Should I resend the patch or just drop
> it?
>
> Guillaume.
>
> --
> Guillaume Morin <guillaume@morinfr.org>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-06-28 7:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 1:46 [PATCH v2 1/1] staging: iio: ad9850.c: fix checkpatch.pl error Guillaume Morin
2014-06-28 2:09 ` Greg Kroah-Hartman
2014-06-28 2:30 ` Guillaume Morin
2014-06-28 2:37 ` Greg Kroah-Hartman
2014-06-28 3:10 ` Guillaume Morin
2014-06-28 6:35 ` Michael Welling
2014-06-28 7:00 ` Michael Welling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140628070041.GA3846@deathray \
--to=mwelling@ieee.org \
--cc=gregkh@linuxfoundation.org \
--cc=guillaume@morinfr.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).