From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 29 Jun 2014 12:49:01 +0100 From: Russell King - ARM Linux To: Jonathan Cameron Cc: Fabio Estevam , Lars-Peter Clausen , Samuel Ortiz , Eric =?iso-8859-1?Q?B=E9nard?= , linux-iio@vger.kernel.org, Dmitry Torokhov , Denis Carikli , Sascha Hauer , linux-input@vger.kernel.org, Markus Pargmann , Shawn Guo , Lee Jones , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 2/6] input: touchscreen: imx25 tcq driver Message-ID: <20140629114901.GO32514@n2100.arm.linux.org.uk> References: <1392913312-9030-1-git-send-email-mpa@pengutronix.de> <1402672899-6995-1-git-send-email-denis@eukrea.com> <1402672899-6995-3-git-send-email-denis@eukrea.com> <53A55BD8.7030905@kernel.org> <53AFF1C4.1010402@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <53AFF1C4.1010402@kernel.org> Sender: Russell King - ARM Linux List-ID: On Sun, Jun 29, 2014 at 12:00:20PM +0100, Jonathan Cameron wrote: > On 21/06/14 20:55, Fabio Estevam wrote: >> On Sat, Jun 21, 2014 at 7:18 AM, Jonathan Cameron wrote: >>>> + >>>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>> >>> Could this not in theory fail? >> >> Yes, but devm_ioremap_resource will take care of it, so we don't need >> to check for error here. > Nothing like counter intuitive behaviour. Ah well. > > Thanks for explaining this! Maybe it would be better to have: mem = platform_ioremap_resource(pdev, IORESOURCE_MEM, 0); which wraps up both the platform_get_resource() call with devm_ioremap_resource() so driver writers don't have to be concerned about this aspect? -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it.