From: Martin Fuzzey <mfuzzey@parkeon.com>
To: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>
Subject: [PATCH 8/8] iio: mma8452: Add support for interrupt driven triggers.
Date: Wed, 23 Jul 2014 19:17:36 +0200 [thread overview]
Message-ID: <20140723171736.22067.63289.stgit@localhost> (raw)
In-Reply-To: <20140723171719.22067.79447.stgit@localhost>
Implement interrupt driven trigger for data ready.
This allows more efficient access to the sample data.
Signed-off-by: Martin Fuzzey <mfuzzey@parkeon.com>
---
drivers/iio/accel/mma8452.c | 86 +++++++++++++++++++++++++++++++++++++++++--
1 file changed, 82 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index c56d34e..f5ee5f2 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel/mma8452.c
@@ -18,6 +18,8 @@
#include <linux/iio/sysfs.h>
#include <linux/iio/trigger_consumer.h>
#include <linux/iio/buffer.h>
+#include <linux/iio/trigger.h>
+#include <linux/iio/trigger_consumer.h>
#include <linux/iio/triggered_buffer.h>
#include <linux/iio/events.h>
#include <linux/delay.h>
@@ -560,6 +562,11 @@ static irqreturn_t mma8452_interrupt(int irq, void *p)
if (src < 0)
goto out;
+ if (src & MMA8452_INT_DRDY) {
+ iio_trigger_poll_chained(indio_dev->trig, iio_get_time_ns());
+ ret = IRQ_HANDLED;
+ }
+
if (src & MMA8452_INT_TRANS) {
mma8452_transient_interrupt(indio_dev);
ret = IRQ_HANDLED;
@@ -699,6 +706,67 @@ static const struct iio_info mma8452_info = {
static const unsigned long mma8452_scan_masks[] = {0x7, 0};
+static int mma8452_data_rdy_trigger_set_state(struct iio_trigger *trig,
+ bool state)
+{
+ struct iio_dev *indio_dev = iio_trigger_get_drvdata(trig);
+ struct mma8452_data *data = iio_priv(indio_dev);
+ int reg;
+
+ reg = i2c_smbus_read_byte_data(data->client, MMA8452_CTRL_REG4);
+ if (reg < 0)
+ return reg;
+
+ if (state)
+ reg |= MMA8452_INT_DRDY;
+ else
+ reg &= ~MMA8452_INT_DRDY;
+
+ return mma8452_change_config(data, MMA8452_CTRL_REG4, reg);
+}
+
+static const struct iio_trigger_ops mma8452_trigger_ops = {
+ .set_trigger_state = mma8452_data_rdy_trigger_set_state,
+ .owner = THIS_MODULE,
+};
+
+static int mma8452_trigger_setup(struct iio_dev *indio_dev)
+{
+ struct mma8452_data *data = iio_priv(indio_dev);
+ struct iio_trigger *trig;
+ int ret;
+
+ trig = iio_trigger_alloc("%s-dev%d", indio_dev->name,
+ indio_dev->id);
+ if (!trig)
+ return -ENOMEM;
+
+ trig->dev.parent = &data->client->dev;
+ trig->ops = &mma8452_trigger_ops;
+ iio_trigger_set_drvdata(trig, indio_dev);
+
+ ret = iio_trigger_register(trig);
+ if (ret)
+ goto err_trigger_free;
+
+ indio_dev->trig = trig;
+
+ return 0;
+
+err_trigger_free:
+ iio_trigger_free(trig);
+
+ return ret;
+}
+
+static void mma8452_trigger_cleanup(struct iio_dev *indio_dev)
+{
+ if (indio_dev->trig) {
+ iio_trigger_unregister(indio_dev->trig);
+ iio_trigger_free(indio_dev->trig);
+ }
+}
+
static int mma8452_reset(struct i2c_client *client)
{
int i;
@@ -770,7 +838,8 @@ static int mma8452_probe(struct i2c_client *client,
return ret;
if (client->irq) {
- int supported_interrupts = MMA8452_INT_TRANS;
+ int supported_interrupts = MMA8452_INT_DRDY | MMA8452_INT_TRANS;
+ int enabled_interrupts = MMA8452_INT_TRANS;
/* Assume wired to INT1 pin */
ret = i2c_smbus_write_byte_data(client,
@@ -781,7 +850,11 @@ static int mma8452_probe(struct i2c_client *client,
ret = i2c_smbus_write_byte_data(client,
MMA8452_CTRL_REG4,
- supported_interrupts);
+ enabled_interrupts);
+ if (ret < 0)
+ return ret;
+
+ ret = mma8452_trigger_setup(indio_dev);
if (ret < 0)
return ret;
}
@@ -791,12 +864,12 @@ static int mma8452_probe(struct i2c_client *client,
ret = i2c_smbus_write_byte_data(client, MMA8452_CTRL_REG1,
data->ctrl_reg1);
if (ret < 0)
- return ret;
+ goto trigger_cleanup;
ret = iio_triggered_buffer_setup(indio_dev, NULL,
mma8452_trigger_handler, NULL);
if (ret < 0)
- return ret;
+ goto trigger_cleanup;
ret = iio_device_register(indio_dev);
if (ret < 0)
@@ -818,6 +891,10 @@ device_cleanup:
buffer_cleanup:
iio_triggered_buffer_cleanup(indio_dev);
+
+trigger_cleanup:
+ mma8452_trigger_cleanup(indio_dev);
+
return ret;
}
@@ -827,6 +904,7 @@ static int mma8452_remove(struct i2c_client *client)
iio_device_unregister(indio_dev);
iio_triggered_buffer_cleanup(indio_dev);
+ mma8452_trigger_cleanup(indio_dev);
mma8452_standby(iio_priv(indio_dev));
return 0;
prev parent reply other threads:[~2014-07-23 17:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 17:17 [PATCH 0/8] iio: mma8452 enhancements Martin Fuzzey
2014-07-23 17:17 ` [PATCH 1/8] iio: mma8452: Initialise before activating Martin Fuzzey
2014-07-23 18:05 ` Peter Meerwald
2014-07-28 15:53 ` Martin Fuzzey
2014-07-23 17:17 ` [PATCH 2/8] iio: mma8452: Add access to registers via DebugFS Martin Fuzzey
2014-07-23 17:17 ` [PATCH 3/8] iio: mma8452: Basic support for transient events Martin Fuzzey
2014-07-23 18:12 ` Peter Meerwald
2014-07-28 13:37 ` Martin Fuzzey
2014-07-28 19:34 ` Jonathan Cameron
2014-07-23 17:17 ` [PATCH 4/8] iio: mma8452: Add support for transient event debouncing Martin Fuzzey
2014-07-23 18:20 ` Peter Meerwald
2014-07-28 13:41 ` Martin Fuzzey
2014-07-23 17:17 ` [PATCH 5/8] iio: core: add high pass filter attributes Martin Fuzzey
2014-07-23 17:17 ` [PATCH 6/8] io: mma8452: Add highpass filter configuration Martin Fuzzey
2014-07-23 17:17 ` [PATCH 7/8] iio: mma8452: add an attribute to enable the highpass filter Martin Fuzzey
2014-07-23 18:36 ` Peter Meerwald
2014-07-28 13:59 ` Martin Fuzzey
2014-07-23 17:17 ` Martin Fuzzey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723171736.22067.63289.stgit@localhost \
--to=mfuzzey@parkeon.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).