linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Felipe Balbi <balbi@ti.com>, <jic23@kernel.org>,
	<linux-iio@vger.kernel.org>
Subject: Re: [RFC/PATCH v2] iio: light: add support for TI's opt3001 ligth sensor
Date: Mon, 11 Aug 2014 09:58:04 -0500	[thread overview]
Message-ID: <20140811145804.GG20177@saruman.home> (raw)
In-Reply-To: <alpine.DEB.2.01.1408111641170.1145@pmeerw.net>

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]

On Mon, Aug 11, 2014 at 04:46:07PM +0200, Peter Meerwald wrote:
> 
> > TI's opt3001 light sensor is a simple and yet powerful
> > little device. The device provides 99% IR rejection,
> > Automatic full-scale, very low power consumption and
> > measurements from 0.01 to 83k lux.
> > 
> > This patch adds support for that device using the IIO
> > framework.
> 
> moving in the right direction, the driver got simpler :)
> 
> light is still misspelled in the subject, the Kconfig needs to be fixed, 
> see below

hah! missed that. Fixed.

> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> >  drivers/iio/light/Kconfig   |  12 +
> >  drivers/iio/light/Makefile  |   1 +
> >  drivers/iio/light/opt3001.c | 739 ++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 752 insertions(+)
> >  create mode 100644 drivers/iio/light/opt3001.c
> > 
> > diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
> > index bf05ca5..e4582d7 100644
> > --- a/drivers/iio/light/Kconfig
> > +++ b/drivers/iio/light/Kconfig
> > @@ -128,6 +128,18 @@ config LTR501
> >  	 This driver can also be built as a module.  If so, the module
> >           will be called ltr501.
> >  
> > +config OPT3001
> > +	tristate "Texas Instruments OPT3001 Light Sensor"
> > +	depends on I2C
> > +	select IIO_BUFFER
> > +	select IIO_TRIGGERED_BUFFER
> 
> IIO_BUFFER, IIO_TRIGGERED_BUFFER not needed since not supported by driver

fixed.

both pushed to my branch at kernel.org

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2014-08-11 14:58 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-06 16:10 [RFC/PATCH] iio: light: add support for TI's opt3001 ligth sensor Felipe Balbi
2014-08-06 21:11 ` Peter Meerwald
2014-08-06 21:42   ` Felipe Balbi
2014-08-06 22:09     ` Peter Meerwald
2014-08-06 22:18       ` Felipe Balbi
2014-08-06 22:25         ` Peter Meerwald
2014-08-06 22:30           ` Felipe Balbi
2014-08-06 22:35             ` Peter Meerwald
2014-08-06 22:38               ` Felipe Balbi
2014-08-07 10:13                 ` Jonathan Cameron
2014-08-07 10:08     ` Jonathan Cameron
2014-08-07 14:39       ` Felipe Balbi
2014-08-07 16:27         ` Jonathan Cameron
2014-08-07 16:36           ` Felipe Balbi
2014-08-07 17:00             ` Jonathan Cameron
2014-08-07 10:01 ` Jonathan Cameron
2014-08-07 14:28   ` Felipe Balbi
2014-08-07 16:26     ` Jonathan Cameron
2014-08-07 16:30       ` Jonathan Cameron
2014-08-07 16:35       ` Felipe Balbi
2014-08-07 16:58         ` Jonathan Cameron
2014-08-07 17:54           ` Felipe Balbi
2014-08-11 14:34 ` [RFC/PATCH v2] " Felipe Balbi
2014-08-11 14:46   ` Peter Meerwald
2014-08-11 14:58     ` Felipe Balbi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140811145804.GG20177@saruman.home \
    --to=balbi@ti.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).