From: Guenter Roeck <linux@roeck-us.net>
To: Johannes Pointner <johannes.pointner@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: iio: iio_channel_get: ntc_thermistor isn't working since patch for of_iio_channel_get_by_name()
Date: Thu, 21 Aug 2014 06:25:56 -0700 [thread overview]
Message-ID: <20140821132556.GA24224@roeck-us.net> (raw)
In-Reply-To: <CAJKbBDBCEVfB-f6W1NbpPhuyduYB4KQMoT=9=wF4yny3a6weKA@mail.gmail.com>
On Thu, Aug 21, 2014 at 09:29:56AM +0200, Johannes Pointner wrote:
> Hello,
>
> I found out that since this patch https://lkml.org/lkml/2014/6/11/201,
> which fixes the return values in this function, the ntc_thermistor
> driver isn't working anymore for me.
> The problem is that before the driver asked for probe deferral because
> the adc driver isn't loaded at this point and now the probe fails in
> the function iio_channel_get_sys and returns -ENODEV.
> My question is: Who is in this case responsible to request a deferral?
> The driver or the subsystem?
>
Unless I am missing something, iio_get_channel() should request probe deferral.
There is no other way for the driver to know that the adc driver is not loaded
yet.
The problem here may be that the devicetree entry for the ntc_thermistor driver
may not be correct. The above referenced patch fixes a bug in that area, and
devicetree data is now better validated.
Guenter
next prev parent reply other threads:[~2014-08-21 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 7:29 iio: iio_channel_get: ntc_thermistor isn't working since patch for of_iio_channel_get_by_name() Johannes Pointner
2014-08-21 13:25 ` Guenter Roeck [this message]
2014-08-22 11:50 ` Johannes Pointner
2014-08-22 13:32 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821132556.GA24224@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jic23@kernel.org \
--cc=johannes.pointner@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).