From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: IIO <linux-iio@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Hartmut Knaack <knaack.h@gmx.de>,
Ramakrishna Pallala <ramakrishna.pallala@intel.com>
Subject: Re: [PATCH v2 4/4] iio/adc/axp288: add support for axp288 gpadc
Date: Fri, 19 Sep 2014 09:43:10 -0700 [thread overview]
Message-ID: <20140919094310.6f045021@ultegra> (raw)
In-Reply-To: <alpine.DEB.2.01.1409091509110.26919@pmeerw.net>
On Tue, 9 Sep 2014 15:46:31 +0200 (CEST)
Peter Meerwald <pmeerw@pmeerw.net> wrote:
> > +static int axp288_gpadc_remove(struct platform_device *pdev)
> > +{
> > + struct iio_dev *indio_dev = platform_get_drvdata(pdev);
> > +
> > + iio_device_unregister(indio_dev);
> > + iio_map_array_unregister(indio_dev);
>
> axp288_gpadc_enable(axp2xx->regmap, false);
on a second thought, we should not disable the adc even on driver
removal. otherwise, internal fuel gauge will be affected.
next prev parent reply other threads:[~2014-09-19 16:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 13:02 [PATCH v2 0/4] Initial support for XPowers AXP288 PMIC Jacob Pan
2014-09-09 13:02 ` [PATCH v2 1/4] mfd/axp20x: rename files to support more devices Jacob Pan
2014-09-10 8:12 ` Lee Jones
2014-09-09 13:02 ` [PATCH v2 2/4] mfd/axp2xx: extend axp20x to support axp288 pmic Jacob Pan
2014-09-10 8:25 ` Maxime Ripard
2014-09-10 9:13 ` Lee Jones
2014-09-10 20:11 ` Jacob Pan
2014-09-09 13:02 ` [PATCH v2 3/4] regulator/axp20x: use axp2xx consolidated header Jacob Pan
2014-09-09 13:02 ` [PATCH v2 4/4] iio/adc/axp288: add support for axp288 gpadc Jacob Pan
2014-09-09 13:46 ` Peter Meerwald
2014-09-11 12:05 ` Jacob Pan
2014-09-19 16:43 ` Jacob Pan [this message]
2014-09-19 17:31 ` Srinivas Pandruvada
2014-09-19 19:47 ` Jacob Pan
2014-09-21 12:22 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919094310.6f045021@ultegra \
--to=jacob.jun.pan@linux.intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=ramakrishna.pallala@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).