From: Brian Vandre <bvandre@gmail.com>
To: gregkh@linuxfoundation.org, jic23@kernel.org,
alexandre.belloni@free-electrons.com, linux-iio@vger.kernel.org,
marex@denx.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: iio: adc: fix line over 80 characters
Date: Thu, 23 Oct 2014 07:53:36 -0500 [thread overview]
Message-ID: <20141023125336.GB10433@brian-U> (raw)
In-Reply-To: <ec4b497827f6c7615f6b5eef5669144f8c68d034.1413931615.git.bvandre@gmail.com>
With all the replies I have gotten it seems like there might not be a good path forward
with this patch. I am starting to agree with what Daniel Baluta said above that this doesn't
make the code easier to read. All the other suggestions don't quite fit the same style
as the rest of the file so it might just be better to leave it.
This being my first try I thank you all for your input. It has helped me learn quite a bit.
Hopefully on the next patch I can fix something a little more meaningful!
Thanks,
Brian Vandre
next prev parent reply other threads:[~2014-10-23 12:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 2:48 [PATCH 0/2] Staging: iio: adc: Checkpatch.pl warning cleanups Brian Vandre
2014-10-21 2:48 ` [PATCH 1/2] Staging: iio: adc: fix line over 80 characters Brian Vandre
2014-10-23 10:39 ` Daniel Baluta
2014-10-21 2:48 ` [PATCH 2/2] " Brian Vandre
2014-10-21 7:29 ` [PATCH 0/2] Staging: iio: adc: Checkpatch.pl warning cleanups Alexandre Belloni
2014-10-21 22:56 ` [PATCH v2] " Brian Vandre
2014-10-21 22:56 ` [PATCH v2] Staging: iio: adc: fix line over 80 characters Brian Vandre
2014-10-22 4:21 ` Sudip Mukherjee
2014-10-22 23:47 ` Hartmut Knaack
2014-10-23 2:02 ` Brian Vandre
2014-10-23 3:23 ` Joe Perches
2014-10-23 9:46 ` Sudip Mukherjee
2014-10-23 10:50 ` Lars-Peter Clausen
2014-10-23 12:42 ` Brian Vandre
2014-10-23 12:53 ` Brian Vandre [this message]
2014-10-23 13:27 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023125336.GB10433@brian-U \
--to=bvandre@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox