From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 23 Oct 2014 15:27:34 +0200 From: Alexandre Belloni To: Brian Vandre Cc: gregkh@linuxfoundation.org, jic23@kernel.org, linux-iio@vger.kernel.org, marex@denx.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Staging: iio: adc: fix line over 80 characters Message-ID: <20141023132733.GB10477@piout.net> References: <20141023125336.GB10433@brian-U> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20141023125336.GB10433@brian-U> List-ID: Hi, On 23/10/2014 at 07:53:36 -0500, Brian Vandre wrote : > With all the replies I have gotten it seems like there might not be a good path forward > with this patch. I am starting to agree with what Daniel Baluta said above that this doesn't > make the code easier to read. All the other suggestions don't quite fit the same style > as the rest of the file so it might just be better to leave it. > > This being my first try I thank you all for your input. It has helped me learn quite a bit. > > Hopefully on the next patch I can fix something a little more meaningful! > Thank you for your effort anyway. My last comment would be that you don't need a cover letter when sending only one patch. There are plenty of things to fix in the kernel, maybe we can help you find something. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com