From: Vlad Dogaru <vlad.dogaru@intel.com>
To: Hartmut Knaack <knaack.h@gmx.de>
Cc: IIO <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 1/3]iio:pressure:bmp280: fix pressure calculation
Date: Fri, 31 Oct 2014 13:43:11 +0200 [thread overview]
Message-ID: <20141031114311.GA24473@vdogaru> (raw)
In-Reply-To: <5452E454.8040607@gmx.de>
On Fri, Oct 31, 2014 at 02:22:28AM +0100, Hartmut Knaack wrote:
> According to the datasheet and as defined in struct bmp280_comp_press, dig_p1 is
> of type u16, while dig_p2 to dig_p9 are of type s16. In
> bmp280_read_compensation_press(), values read from the device were treated as
> the wrong type.
> In bmp280_read_press() the fractional part of the measured pressure is
> calculated wrong. A better way is to use *val for the raw pressure and *val2 for
> the quotient and let the core do the proper conversion using IIO_VAL_FRACTIONAL.
>
> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
Acked-by: Vlad Dogaru <vlad.dogaru@intel.com>
next prev parent reply other threads:[~2014-10-31 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 1:22 [PATCH 1/3]iio:pressure:bmp280: fix pressure calculation Hartmut Knaack
2014-10-31 11:43 ` Vlad Dogaru [this message]
2014-11-05 15:57 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141031114311.GA24473@vdogaru \
--to=vlad.dogaru@intel.com \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox