From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, marex@denx.de, fabio.estevam@freescale.com,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: mxs-lradc: fix iio channel map regression
Date: Sat, 3 Jan 2015 17:53:06 +0100 [thread overview]
Message-ID: <20150103165306.GK4194@piout.net> (raw)
In-Reply-To: <1420139477-2361-1-git-send-email-stefan.wahren@i2se.com>
Hi,
On 01/01/2015 at 19:11:17 +0000, Stefan Wahren wrote :
> Since commit c8231a9af8147f8a ("iio: mxs-lradc: compute temperature
> from channel 8 and 9") with the removal of adc channel 9 there is
> no 1-1 mapping in the channel spec.
>
> All hwmon channel values above 9 are accessible via there index minus
> one. So add a "bogus" iio channel 9 to fix this issue.
>
I think the preferred way of doing that was explained there:
https://lkml.org/lkml/2014/6/14/69
Can you take care of that?
Thanks!
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> drivers/staging/iio/adc/mxs-lradc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
> index d9d6fad..126a07b 100644
> --- a/drivers/staging/iio/adc/mxs-lradc.c
> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> @@ -1413,6 +1413,7 @@ static const struct iio_chan_spec mxs_lradc_chan_spec[] = {
> .channel = 8,
> .scan_type = {.sign = 'u', .realbits = 18, .storagebits = 32,},
> },
> + MXS_ADC_CHAN(9, IIO_VOLTAGE),
> MXS_ADC_CHAN(10, IIO_VOLTAGE), /* VDDIO */
> MXS_ADC_CHAN(11, IIO_VOLTAGE), /* VTH */
> MXS_ADC_CHAN(12, IIO_VOLTAGE), /* VDDA */
> --
> 1.7.9.5
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-01-03 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-01 19:11 [PATCH] iio: mxs-lradc: fix iio channel map regression Stefan Wahren
2015-01-03 16:53 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150103165306.GK4194@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=fabio.estevam@freescale.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
--cc=pmeerw@pmeerw.net \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).